[Pkg-lxde-maintainers] Bug#836112: lxdm: don't run dbus-launch if XDG_RUNTIME_DIR/bus is available

[Simon McVittie]

Source: lxdm
Version: 0.5.3-1
Severity: normal
Tags: upstream
User: dbus at packages.debian.org
Usertags: dbus-launch dbus-launch-unless-dsba

As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
lxdm has code that explicitly runs dbus-launch if
DBUS_SESSION_BUS_ADDRESS isn't set, in data/Xsession.

The major D-Bus implementations (libdbus, GDBus, sd-bus) now have a
fallback code path, before trying X11 autolaunch, when
DBUS_SESSION_BUS_ADDRESS is unset: if XDG_RUNTIME_DIR is set, and
XDG_RUNTIME_DIR/bus exists, is a socket and is owned by the
process's uid, then they will use it. In particular, dbus-user-session
sets up that situation.

For the moment, dbus-user-session does make sure DBUS_SESSION_BUS_ADDRESS
is set, to be nice to packages that don't have this fallback path.
However, I'd like to avoid requiring that in future, by adapting
the dbus-launch code in lxdm and similar session-starters to
look for XDG_RUNTIME_DIR/bus, and not run dbus-launch if that socket
is available.

This code path should in fact never be necessary in Debian, because if
dbus-x11 is not installed it will fail, and if dbus-x11 is installed
DBUS_SESSION_BUS_ADDRESS will already be set.

Thanks,
    S