[Pkg-lxde-maintainers] Bug#831866: lxpanel: launchtaskbar plugin crashes when right clicking on java-application

[Lutz Fischer]

Package: lxpanel
Version: 0.8.2-1
Severity: important
Tags: upstream patch

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?
   right click on icon of java application (e.g. netbeans)
   * What exactly did you do (or not do) that was effective (or
     ineffective)?
   changed the source code and recompiled
   * What was the outcome of this action?
   worked
   * What outcome did you expect instead?
   worked

*** End of the template - remove these template lines ***

The problem seems to be, that 
menu_cache_app_get_exec
can return NULL but subsequent usages of the return value do not test
for that.

So I changed the code as follows:

diff -ur lxpanel-0.8.2/plugins/launchtaskbar.c
lxpanel-0.8.2-1.1/plugins/launchtaskbar.c
--- lxpanel-0.8.2/plugins/launchtaskbar.c2016-02-20 22:27:59.000000000
+0000
+++ lxpanel-0.8.2-1.1/plugins	/launchtaskbar.c2016-07-20
11:15:22.653472780 +0100
@@ -303,7 +303,7 @	@
     if (l == NULL) for (l = apps; l; l = l->next)
     {
         exec = menu_cache_app_get_exec(MENU_CACHE_APP(l->data));
-        if (exec[0] != '/' && strncmp(exec, short_exec, len) == 0 &&
+        if (exec != NULL && exec[0] != '/' && strncmp(exec, short_exec,
len) == 0 &&
             (exec[len] == ' ' || exec[len] == 0))
             break;
     }
@@ -315,7 +315,7 @@
         for (l = apps; l; l = l->next)
         {
             exec = menu_cache_app_get_exec(MENU_CACHE_APP(l->data));
-            if (exec[0] == '/' && strncmp(exec, exec_bin, len) == 0 &&
+            if (exec != NULL && exec[0] == '/' && strncmp(exec,
exec_bin, len) == 0 &&
                 (exec[len] == ' ' || exec[len] == 0))
                 break;
         }


this seem to fix the crash.

Lutz Fischer


-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE= (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages lxpanel depends on:
ii  libasound2           1.1.1-2
ii  libatk1.0-0          2.20.0-1
ii  libc6                2.23-1
ii  libcairo2            1.14.6-1+b1
ii  libfm-gtk4           1.2.4-1
ii  libfm-modules        1.2.4-1
ii  libfm4               1.2.4-1
ii  libfontconfig1       2.11.0-6.4
ii  libfreetype6         2.6.3-3+b1
ii  libgdk-pixbuf2.0-0   2.34.0-1
iu  libglib2.0-0         2.48.1-2
ii  libgtk2.0-0          2.24.30-2
ii  libiw30              30~pre9-11
ii  libkeybinder0        0.3.1-1
ii  libmenu-cache3       1.0.1-1
ii  libpango-1.0-0       1.40.1-1
ii  libpangocairo-1.0-0  1.40.1-1
ii  libpangoft2-1.0-0    1.40.1-1
ii  libwnck22            2.30.7-5
ii  libx11-6             2:1.6.3-1
ii  libxml2              2.9.3+dfsg1-1.2
ii  lxmenu-data          0.1.5-1
iu  lxpanel-data         0.8.2-1

Versions of packages lxpanel recommends:
ii  evilvte [x-terminal-emulator]         0.5.1-1
ii  gnome-terminal [x-terminal-emulator]  3.20.2-1
ii  konsole [x-terminal-emulator]         4:16.04.2-1
ii  lxterminal [x-terminal-emulator]      0.2.0-1
ii  mate-terminal [x-terminal-emulator]   1.14.0-1
ii  mlterm [x-terminal-emulator]          3.5.0-1+b1
ii  pavucontrol                           3.0-3+b2
ii  pterm [x-terminal-emulator]           0.67-2
ii  qterminal [x-terminal-emulator]       0.6.0+20160104-1
ii  rxvt [x-terminal-emulator]            1:2.7.10-7
ii  rxvt-ml [x-terminal-emulator]         1:2.7.10-7
ii  rxvt-unicode [x-terminal-emulator]    9.22-1
ii  sakura [x-terminal-emulator]          3.3.4-2
ii  terminology [x-terminal-emulator]     0.7.0-1
ii  xfce4-terminal [x-terminal-emulator]  0.6.3-2
ii  xkb-data                              2.17-1
ii  xterm [x-terminal-emulator]           325-1
ii  xvt [x-terminal-emulator]             2.1-20.2

Versions of packages lxpanel suggests:
ii  chromium [www-browser]          51.0.2704.79-1
ii  dillo [www-browser]             3.0.5-2+b1
ii  dwb [www-browser]               20150419git-2+b1
ii  elinks [www-browser]            0.12~pre6-11+b2
ii  epiphany-browser [www-browser]  3.20.3-2
ii  firefox-esr [www-browser]       45.2.0esr-1
ii  iceweasel                       45.2.0esr-1
ii  konqueror [www-browser]         4:16.04.2-1+b1
ii  links2 [www-browser]            2.13-1
ii  lynx [www-browser]              2.8.9dev9-1
ii  menu                            2.1.47
ii  midori [www-browser]            0.5.11-ds1-2
ii  qupzilla [www-browser]          1.8.9~dfsg1-3
ii  uzbl [www-browser]              0.0.0~git.20120514-1.2
ii  w3m [www-browser]               0.5.3-28

-- no debconf information