[Pkg-lxde-maintainers] Bug#874657: pcmanfm: should have explicit recommends on lxpolkit | polkit-1-auth-agent

[Raphaël Hertzog]

Source: pcmanfm
Version: 1.2.5-3
Severity: important
Tags: patch
User: devel at kali.org
Usertags: origin-kali kali-patch

The LXDE image produced by Kali is severly broken and the cause is that
"apt install lxde" ends up installing a mix of lxde and lxqt.

« apt -o Debug::pkgDepCache::AutoInstall="yes" install lxde » shows this:
[...]
    Installing lxqt-policykit as Recommande of pcmanfm
      Installing liblxqt0 as Dépend of lxqt-policykit
[...]
      Installing libpolkit-qt5-1-1 as Dépend of lxqt-policykit
      Installing lxqt-session as Dépend of lxqt-policykit

At the end, ligthdm starts the lxqt session but it is broken
because lxqt-panel is not installed.

The fix is simply to change the Recommends from « polkit-1-auth-agent | policykit-1-gnome »
to « lxpolkit | polkit-1-auth-agent | policykit-1-gnome » or maybe only
« lxpolkit ».

diff --git a/debian/control b/debian/control
index 14c4893..1260a27 100644
--- a/debian/control
+++ b/debian/control
@@ -17,7 +17,7 @@ Architecture: any
 Depends: ${misc:Depends}, ${shlibs:Depends}, shared-mime-info
 Recommends:
  gvfs-backends, gvfs-fuse [!hurd-any],
- polkit-1-auth-agent | policykit-1-gnome,
+ lxpolkit | polkit-1-auth-agent | policykit-1-gnome,
  lxde-icon-theme | gnome-icon-theme | oxygen-icon-theme | tango-icon-theme
 Description: extremely fast and lightweight file manager
  PCMan File Manager is a GTK+ based file manager, featuring:


Note that pcmanfm-qt correctly recommends lxqt-policykit and does not even
allow any alternative. I'm not sure that allowing alternatives is a good idea
since you want to ensure a well integrated experience. The policy kits agents
are co-installable anyway so it does not cause any problem.

Thank you!

-- System Information:
Debian Release: buster/sid
  APT prefers oldoldstable
  APT policy: (500, 'oldoldstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.12.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)