[Pkg-lxde-maintainers] Bug#975668: lxpanel FTBFS: includes <gdk-pixbuf-xlib/gdk-pixbuf-xlib.h> without dependency

[Simon McVittie]

Source: lxpanel
Version: 0.10.0-2
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)

To reproduce: build lxpanel on a release architecture in unstable (I used
amd64).

> plugin.c:32:10: fatal error: gdk-pixbuf-xlib/gdk-pixbuf-xlib.h: No such file or directory
>    32 | #include <gdk-pixbuf-xlib/gdk-pixbuf-xlib.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.

This is because the deprecated gdk-pixbuf-xlib-2.0 module used to be
pulled in as an indirect dependency by GTK 2. However, GTK 2 doesn't
actually use that module, and as a result libgtk2.0-dev no longer depends
on it, causing lxpanel to fail to build.

In the short term, please build-depend on either

    libgdk-pixbuf-xlib-2.0-dev | libgdk-pixbuf2.0-dev

if you want backports to older Debian to be possible, or

    libgdk-pixbuf-xlib-2.0-dev

if not. That's enough to close this bug. (This might also be a good
opportunity to check that all the other packages required at build time
are in the Build-Depends.)

For the longer term, the upstream maintainers of gdk-pixbuf have deprecated
the gdk-pixbuf-xlib-2.0 module[0] and do not intend to maintain it further,
so it would be better if lxpanel can stop using it.

Thanks,
    smcv

[0] https://gitlab.gnome.org/Archive/gdk-pixbuf-xlib