[pkg-lxqt-devel] Bug#925346: Regression: Keyboard layout switch shortcut can't be changed

[Alf Gaida]

Package: lxqt-config
Version: 0.14.1-2
Severity: important

Dear Maintainer,

the shortcut for switching keyboard layout cannot be changed, a known upstream
regression. This make working with mutiple keyboard layouts not needed hard.
 

Upstream patch is available, tested and works fine: 


>From dfe9a2b27aab40262b9186672fad480a406d5c4a Mon Sep 17 00:00:00 2001
From: Tsu Jan <tsujan2000 at gmail.com>
Date: Fri, 22 Mar 2019 19:55:32 +0430
Subject: [PATCH] Fixed changing keyboard layout switch shortcut and model

Fixes https://github.com/lxqt/lxqt-config/issues/445
---
 lxqt-config-input/keyboardlayoutconfig.cpp | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/lxqt-config-input/keyboardlayoutconfig.cpp b/lxqt-config-input/keyboardlayoutconfig.cpp
index f5a7f24..bc6c369 100644
--- a/lxqt-config-input/keyboardlayoutconfig.cpp
+++ b/lxqt-config-input/keyboardlayoutconfig.cpp
@@ -40,8 +40,14 @@ KeyboardLayoutConfig::KeyboardLayoutConfig(LXQt::Settings* _settings, QWidget* p
   connect(ui.removeLayout, &QAbstractButton::clicked, this, &KeyboardLayoutConfig::onRemoveLayout);
   connect(ui.moveUp, &QAbstractButton::clicked, this, &KeyboardLayoutConfig::onMoveUp);
   connect(ui.moveDown, &QAbstractButton::clicked, this, &KeyboardLayoutConfig::onMoveDown);
-  connect(ui.keyboardModel, QOverload<int>::of(&QComboBox::activated), this, &KeyboardLayoutConfig::settingsChanged);
-  connect(ui.switchKey, QOverload<int>::of(&QComboBox::activated), this, &KeyboardLayoutConfig::settingsChanged);
+  connect(ui.keyboardModel, QOverload<int>::of(&QComboBox::activated), [this](int /*index*/) {
+    applyConfig_ = true;
+    Q_EMIT settingsChanged();
+  });
+  connect(ui.switchKey, QOverload<int>::of(&QComboBox::activated), [this](int /*index*/) {
+    applyConfig_ = true;
+    Q_EMIT settingsChanged();
+  });
 }
 
 KeyboardLayoutConfig::~KeyboardLayoutConfig() {



Cheers Alf



-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.0.3-towo.1-siduction-amd64 (SMP w/8 CPU cores; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE= (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lxqt-config depends on:
ii  libc6             2.28-8
ii  libkf5screen-bin  4:5.14.5-1
ii  libkf5screen7     4:5.14.5-1
ii  liblxqt0          0.14.1-1
ii  libqt5core5a      5.11.3+dfsg1-1
ii  libqt5gui5        5.11.3+dfsg1-1
ii  libqt5svg5        5.11.3-2
ii  libqt5widgets5    5.11.3+dfsg1-1
ii  libqt5x11extras5  5.11.3-2
ii  libqt5xdg3        3.3.1-1
ii  libqt5xml5        5.11.3+dfsg1-1
ii  libstdc++6        8.3.0-3
ii  libudev1          241-2
ii  libx11-6          2:1.6.7-1
ii  libxcb-randr0     1.13.1-2
ii  libxcb1           1.13.1-2
ii  libxcursor1       1:1.1.15-2
ii  libxfixes3        1:5.0.3-1
ii  libxi6            2:1.7.9-1
ii  zlib1g            1:1.2.11.dfsg-1

Versions of packages lxqt-config recommends:
ii  disk-manager           1.1.1-2
ii  galternatives          1.0.4
ii  lxqt-config-l10n       0.14.1-2
ii  lxqt-policykit         0.14.1-1
ii  lxqt-powermanagement   0.14.1-1
ii  lxqt-qtplugin          0.14.0-2
ii  lxqt-session           0.14.1-1
ii  qt5-style-plugins      5.0.0+git23.g335dbec-2+b17
ii  system-config-printer  1.5.11-4
ii  xsettingsd             0.0.20171105+1+ge4cf9969-1

Versions of packages lxqt-config suggests:
ii  adwaita-qt             1.0-2
ii  cmst                   2019.01.13-1
ii  faenza-icon-theme      1.3.1-2
ii  gnome-themes-standard  3.28-1
ii  gparted                0.32.0-2
ii  lxappearance           0.6.3-1
pn  lxqt | lxqt-core       <none>
ii  obconf-qt              0.14.1-1
ii  synaptic               0.84.5

-- no debconf information