Bug#348592: [Pkg-mailman-hackers] Bug#348592: mailman: Spam causes a moderation loop

[Lionel Elie Mamane]

On Tue, Jan 17, 2006 at 10:24:03PM +0100, Christoph Haas wrote:

> Short story: when filtering mails for spam I get a moderation loop.

> I believe the problem has just recently been dealt with in a later version
> of mailman (as you can see I'm using Sarge). The patch is described at

> http://sourceforge.net/tracker/index.php?func=detail&aid=1405790&group_id=103&atid=300103

> The above patch is meant for version 2.1.7. But I believe the following
> tinier patch would even fix this issue for Sarge

Thank you for your bug report. We cannot fix this in sarge, as sarge
is already released and only security / critical bugfixes are accepted
into point releases.

I'll integrate this in my upload of Mailman 2.1.7.

> --- SpamDetect.py.orig  2006-01-16 14:05:42.000000000 +0100
> +++ SpamDetect.py       2006-01-16 14:05:18.000000000 +0100
> @@ -103,6 +103,15 @@
>          if mo:
>              # we've detected spam, so throw the message away
>              raise SpamDetected
> +    # Before we go to header_filter_rules, we exclude internally generated
> +    # owner notification from checking, because 1) we collect headers from
> +    # all the attachments but this will cause matching the filter rule again,
> +    # and 2) list owners may want to check header name / value pair like
> +    # 'Precedence: bulk' which is also generated by mailman.  Both will
> +    # cause loop of holding owner notification messages if the action is
> +    # set to 'hold'.
> +    if msgdata.get('toowner') and msg.get('x-list-administrivia') == 'yes':
> +        return

Ugh, so all a spam has to do is to put an "x-list-administrivia: yes"
header to get past the rules?

-- 
Lionel