[Pkg-mailman-hackers] Bug#799281: ITP: mailman3-core -- Mailing list management system

Thomas Goirand zigo at debian.org
Fri Dec 4 13:33:28 UTC 2015


On 12/03/2015 05:08 PM, Pierre-Elliott Bécue wrote:
>> * It's looking like your postinst does nothing, am I missing something?
> 
> It is supposed to call systemctl enable mailman3.service at last. Still
> thinking about how to do proper things.

If you just remove your postinst, and add --with systemd in your
debian/rules, then it will be automatically done. Here, your postinst
doesn't even have a #DEBHELPER#, so it wont work, as much as I know (or
am I missing something?).

>> * It doesn't look like your package is producing an init script. Please
>> provide a sysv-rc script. Instead of manually installing the systemd
>> .service file, I'd recommend just moving debian/contrib/*.service to
>> debian/.
> 
> Oh, that works automagically when mailman3.service is in debian? Didn't knew
> that!

It does, as long as you have --with systemd and build-depend on dh-systemd.

> I'm working on a sysv service file, will definitely add it.

Cool!

>> * IMO, you should be providing a mailman3-doc package using sphinx-build.
> 
> make html makes external imports from jquery and mathjax, that would break
> policy regarding privacy. So I'm tied to make latex doc, except if there is
> a proper way to remove these external imports.

You can always patch this, and link to a local version. Both of these
javascript libs are in Debian, so your local file next to the docs could
be a symlink to the libjs-* package(s).

I hope this helps,
Cheers,

Thomas Goirand (zigo)




More information about the Pkg-mailman-hackers mailing list