[Pkg-mailman-hackers] Bug#884259: Bug#884259: mailman3-suite: postinst fails to finish due to password/keys containing '/'

[Pierre-Elliott Bécue]

Le mercredi 13 décembre 2017 à 11:14:53+1100, Stephen Rothwell a écrit :
> Package: mailman3-suite
> Version: 0+20170523-1
> Severity: normal
> 
> Dear Maintainer,
> 
>    * What led up to the situation?
> 
> Trying to install mailman3-suite
> 
>    * What exactly did you do (or not do) that was effective (or
>      ineffective)?
> 
> aptitude install mailman3
> 
>    * What was the outcome of this action?
> 
> The postinst for mailman3-suite reported an error with "sed" and then hung
> 
>    * What outcome did you expect instead?
> 
> I expected the package to install correctly.
> 
> To make the postinst complete, I changed the 'sed' lines to use '|'
> instead of '/' in their 's' expressions in the following invocation
> (base64 will never produce '|' characters):
> 
>     # Set custom settings in settings_local.py
>     sed -i -e "s|^\(\s*SECRET_KEY\s*=\s*'\)\S\+\('\s*\)$|\1$secretkey\2|" \
>            -e "s|^\(\s*MAILMAN_REST_API_PASS\s*=\s*'\)\S\+\('\s*\)|\1$restapipass\2|" \
>            -e "s|^\(\s*MAILMAN_ARCHIVER_KEY\s*=\s*'\)\S\+\('\s*\)|\1$archiverkey\2|" \
>            -e "s|^\(\s*EMAILNAME\s*=\s*'\)\S\+\('\s*\)|\1$emailname\2|" \
>            $settings_local_new
> 
> -- System Information:
> Debian Release: buster/sid
>   APT prefers testing
>   APT policy: (990, 'testing'), (500, 'stable-updates'), (500, 'oldstable-updates'), (500, 'stable'), (500, 'oldstable'), (1, 'unstable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 4.11.0-1-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: sysvinit (via /sbin/init)
> 
> Versions of packages mailman3-suite depends on:
> ii  dbconfig-pgsql            2.0.9
> ii  debconf [debconf-2.0]     1.5.65
> ii  lsb-base                  9.20170808
> ii  mailman3-core             3.1.0-6
> ii  node-less                 1.6.3~dfsg-2
> ii  python                    2.7.14-1
> ii  python-django-hyperkitty  1.1.4-2
> ii  python-django-postorius   1.1.0-1
> ii  python-psycopg2           2.7.3-1
> ii  python-whoosh             2.7.4+git6-g9134ad92-1
> ii  ruby-sass                 3.4.23-1
> ii  ucf                       3.0036
> ii  uwsgi                     2.0.15-10
> ii  uwsgi-plugin-python       2.0.15-10
> 
> Versions of packages mailman3-suite recommends:
> ii  libapache2-mod-proxy-uwsgi  2.0.15-10
> ii  postgresql                  10+188
> 
> mailman3-suite suggests no packages.
> 
> -- Configuration Files:
> /etc/cron.d/mailman3-suite changed [not included]
> 
> -- debconf information:
>   mailman3-suite/pgsql/admin-user: postgres
>   mailman3-suite/internal/skip-preseed: false
>   mailman3-suite/pgsql/authmethod-admin: ident
> * mailman3-suite/remote/host: localhost
>   mailman3-suite/remote/newhost: localhost
>   mailman3-suite/restart-webserver: true
>   mailman3-suite/emailname: ozlabs.org
>   mailman3-suite/purge: false
>   mailman3-suite/db/app-user: mailman3suite at localhost
> * mailman3-suite/dbconfig-install: true
>   mailman3-suite/pgsql/method: TCP/IP
>   mailman3-suite/remote/port:
>   mailman3-suite/install-error: abort
>   mailman3-suite/missing-db-package-error: abort
>   mailman3-suite/pgsql/no-empty-passwords:
>   mailman3-suite/upgrade-backup: true
>   mailman3-suite/superuser-mail: root at localhost
>   mailman3-suite/pgsql/changeconf: false
>   mailman3-suite/dbconfig-reinstall: false
>   mailman3-suite/remove-error: abort
>   mailman3-suite/reconfigure-webserver: apache2
>   mailman3-suite/pgsql/authmethod-user: password
>   mailman3-suite/dbconfig-remove: true
>   mailman3-suite/superuser-name: admin
>   mailman3-suite/database-type: pgsql
>   mailman3-suite/internal/reconfiguring: false
>   mailman3-suite/db/dbname: mailman3suite
>   mailman3-suite/upgrade-error: abort
>   mailman3-suite/pgsql/manualconf:
>   mailman3-suite/passwords-do-not-match:
>   mailman3-suite/dbconfig-upgrade: true
> 

Good evening,

Yes, this issue was spotted, but after the initial upload in NEW of
mailman-suite. The patch is actually in the git repo since Nov. the 13th[1].
I believe for some reason we failed at uploading the new version. Sorry for
that.

CC-ing mejo as I can't upload a fix myself for now.

-- 
Pierre-Elliott Bécue
GPG: 9AE0 4D98 6400 E3B6 7528  F493 0D44 2664 1949 74E2

[1]:
https://anonscm.debian.org/git/pkg-mailman/mailman-suite.git/commit/?id=a7fc6f9ab063a45115fbeb0d824c181b69ad8e1b
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-mailman-hackers/attachments/20171213/93e6ccdd/attachment-0001.sig>