[Pkg-mailman-hackers] Bug#884330: mailman3-suite: sysv init fails restart for various reasons

[Stephen Rothwell]

Package: mailman3-suite
Version: 0+20170523-2
Severity: normal

Dear Maintainer,

The sysv init script will fail to do a stop or restart:

    --die-on-term is passed to uwsgi, so a TERM signal is needed
	to stop it instead of HUP
    uwsgi takes some time to terminate, so a following start may fail
	if it is still stopping
    stop sill fail if uwsgi is not actually running (which makes
	restart fail)

To fix all this, I changed do_stop to do:

    start-stop-daemon --stop --quiet --oknodo --retry forever/TERM/5 \
	--pidfile $PIDFILE --exec $DAEMON

The "forever" may not be a good choice ... maybe "TERM/5/KILL/5" or
some such would be better. And 5 seconds may also not be a good choice,
but it seems to work fairly well on my setup.

I am also not sure that the {forced-}reload actions are going to work.

Also, maybe start-stop-daemon is not needed for uwsgi as it seems to do
its own process management?

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable-updates'), (500, 'oldstable-updates'), (500, 'stable'), (500, 'oldstable'), (1, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.11.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages mailman3-suite depends on:
ii  dbconfig-pgsql            2.0.9
ii  debconf [debconf-2.0]     1.5.65
ii  lsb-base                  9.20170808
ii  mailman3-core             3.1.0-7
ii  node-less                 1.6.3~dfsg-2
ii  python                    2.7.14-1
ii  python-django-hyperkitty  1.1.4-2
ii  python-django-postorius   1.1.0-1
ii  python-psycopg2           2.7.3-1
ii  python-whoosh             2.7.4+git6-g9134ad92-1
ii  ruby-sass                 3.4.23-1
ii  ucf                       3.0036
ii  uwsgi                     2.0.15-10
ii  uwsgi-plugin-python       2.0.15-10

Versions of packages mailman3-suite recommends:
ii  libapache2-mod-proxy-uwsgi  2.0.15-10
ii  postgresql                  10+188

mailman3-suite suggests no packages.

-- Configuration Files:
/etc/cron.d/mailman3-suite changed [not included]
/etc/init.d/mailman3-suite changed [not included]

-- debconf information:
  mailman3-suite/upgrade-error: abort
  mailman3-suite/install-error: abort
  mailman3-suite/remote/newhost: localhost
  mailman3-suite/restart-webserver: true
  mailman3-suite/pgsql/authmethod-user: password
  mailman3-suite/pgsql/no-empty-passwords:
  mailman3-suite/superuser-name: admin
  mailman3-suite/passwords-do-not-match:
  mailman3-suite/dbconfig-reinstall: false
  mailman3-suite/emailname: ozlabs.org
  mailman3-suite/internal/skip-preseed: false
  mailman3-suite/pgsql/admin-user: postgres
  mailman3-suite/remove-error: abort
  mailman3-suite/dbconfig-remove: true
  mailman3-suite/remote/port:
  mailman3-suite/superuser-mail: root at localhost
  mailman3-suite/pgsql/changeconf: false
  mailman3-suite/pgsql/manualconf:
  mailman3-suite/pgsql/method: TCP/IP
  mailman3-suite/reconfigure-webserver: apache2
  mailman3-suite/dbconfig-upgrade: true
  mailman3-suite/internal/reconfiguring: false
  mailman3-suite/upgrade-backup: true
  mailman3-suite/pgsql/authmethod-admin: ident
  mailman3-suite/database-type: pgsql
  mailman3-suite/db/app-user: mailman3suite at localhost
  mailman3-suite/purge: false
  mailman3-suite/missing-db-package-error: abort
  mailman3-suite/db/dbname: mailman3suite
* mailman3-suite/remote/host: localhost
* mailman3-suite/dbconfig-install: true


-- 
Cheers,
Stephen Rothwell