[Pkg-mailman-hackers] Bug#889637: mailman: please make the build reproducible

[Chris Lamb]

Source: mailman
Version: 1:2.1.26-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that mailman could not be built reproducibly as it includes
a time/timezone/locale-varying timestamp .

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/control	2018-02-05 08:29:56.518472241 +0000
--- b/debian/control	2018-02-05 08:43:41.470576713 +0000
@@ -4,7 +4,7 @@
 Maintainer: Mailman for Debian <pkg-mailman-hackers at lists.alioth.debian.org>
 Uploaders: Thijs Kinkhorst <thijs at debian.org>,
 Build-Depends: debhelper (>= 11), autoconf, python-dev,
- gettext, python-dnspython, dh-python
+ gettext, python-dnspython, dh-python, dh-autoreconf
 Standards-Version: 4.1.3
 Homepage: http://www.list.org/
 Vcs-Git: https://salsa.debian.org/mailman-team/mailman2.git
--- a/debian/patches/92_reproducible_build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/92_reproducible_build.patch	2018-02-05 08:36:21.068801663 +0000
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2018-02-05
+
+--- mailman-2.1.26.orig/configure.in
++++ mailman-2.1.26/configure.in
+@@ -25,7 +25,7 @@ AC_PREFIX_DEFAULT(/usr/local/mailman)
+ 
+ CONFIGURE_OPTS=`echo $@`
+ AC_SUBST(CONFIGURE_OPTS)
+-BUILD_DATE=`date`
++BUILD_DATE=`LC_ALL=C date --utc --date="@${SOURCE_DATE_EPOCH:-$(date +%s)}"`
+ AC_SUBST(BUILD_DATE)
+ 
+ # Check for Python!  Better be found on $PATH
--- a/debian/patches/series	2018-02-05 08:29:56.518472241 +0000
--- b/debian/patches/series	2018-02-05 08:36:20.040817069 +0000
@@ -10,3 +10,4 @@
 79_archiver_slash.patch
 90_gettext_errors.patch
 91_utf8.patch
+92_reproducible_build.patch
--- a/debian/rules	2018-02-05 08:29:56.518472241 +0000
--- b/debian/rules	2018-02-05 08:44:02.218295660 +0000
@@ -33,6 +33,7 @@
 	@debconf-updatepo
 
 Makefile:
+	dh_autoreconf
 	./configure --prefix=/var/lib/$(package) --with-username=list \
 		--with-groupname=list \
 		--with-mail-gid=daemon --with-cgi-gid=www-data \
@@ -46,6 +47,7 @@
 	rm -rf build-stamp Makefile debian/ucffiles debian/mailman.postinst.ucf
 	rm -f debian/mailman.postrm.ucf
 	rm -f debian/preinst
+	dh_autoreconf_clean
 	dh_clean
 	chmod +x debian/{prerm,postinst}