[Pkg-mailman-hackers] Bug#1031928: python3-django-hyperkitty: Javascript not loaded because of HTML error

[Peter J. Holzer]

Package: python3-django-hyperkitty
Version: 1.3.4-4
Severity: grave
Tags: patch
Justification: renders package unusable

Dear Maintainer,

I set up mailman3 including the web interface and the hyperkitty
archiver with Apache2 and a test mailing list.

Upon accessing the archive at
https://<mywebserver>/mailman3/hyperkitty/list/test@<mydomain>/
I immediately noticed that the page was incomplete, showing only
rotating spinners where some of the context should be.

Further investigation showed that the HTML is wrong:

    <script type="text/javascript" src="/mailman3/static/hyperkitty/libs/popper/popper.min.js" />
    <script type="text/javascript" src="/mailman3/static/hyperkitty/libs/bootstrap/javascripts/bootstrap.min.js" />
    ...

In normal HTML (not XHTML) a <script> element needs to be closed with a
</script> tag, the XML-style /> ending is not recognized. The result is
that browsers (at least Firefox and Chromium) ignore all scripts except
the first.

replacing "/>" with "></script>" on the offending lines fixes the
problem

PS: I do notice that those lines are enclosed in
    {% compress js %}...{% endcompress %} so it could also be that that
    doesn't work properly

-- System Information:
Debian Release: 11.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-21-amd64 (SMP w/2 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages python3-django-hyperkitty depends on:
ii  fonts-glyphicons-halflings   1.009~3.4.1+dfsg-2
ii  libjs-bootstrap4             4.5.2+dfsg1-8~deb11u1
ii  libjs-sphinxdoc              3.4.3-2
ii  python3                      3.9.2-3
ii  python3-dateutil             2.8.1-6
ii  python3-django               2:2.2.28-1~deb11u1
ii  python3-django-compressor    2.4-2
ii  python3-django-extensions    3.0.3-3
ii  python3-django-gravatar2     1.4.4-2
ii  python3-django-haystack      3.0-1
ii  python3-django-mailman3      1.3.5-2
ii  python3-django-q             1.2.1-1
ii  python3-djangorestframework  3.12.1-1
ii  python3-elasticsearch        7.1.0-3
ii  python3-flufl.lock           5.0.1-1
ii  python3-mailmanclient        3.3.2-1
ii  python3-networkx             2.5+ds-2
ii  python3-robot-detection      0.4.0-2
ii  python3-tz                   2021.1-1

Versions of packages python3-django-hyperkitty recommends:
ii  mailman3-web  0+20200530-2

python3-django-hyperkitty suggests no packages.

-- no debconf information
-------------- next part --------------
--- orig/base.html	2023-02-25 14:55:29.682952431 +0100
+++ fixed/base.html	2023-02-25 14:55:42.702972701 +0100
@@ -218,18 +218,18 @@
     <script src="{% static 'hyperkitty/libs/jquery/jquery-1.10.1.min.js' %}"></script>
     <script src="{% static 'hyperkitty/libs/jquery/jquery-ui-1.10.3.custom.min.js' %}"></script>
     {% compress js %}
-    <script type="text/javascript" src="{% static 'hyperkitty/libs/popper/popper.min.js' %}" />
-    <script type="text/javascript" src="{% static 'hyperkitty/libs/bootstrap/javascripts/bootstrap.min.js' %}" />
-    <script type="text/javascript" src="{% static 'hyperkitty/libs/mousetrap/mousetrap.min.js' %}" />
-    <script type="text/javascript" src="{% static 'hyperkitty/libs/jquery.expander.js' %}" />
-    <script type="text/javascript" src="{% static 'hyperkitty/libs/d3.v2.min.js' %}" />
-    <script type="text/javascript" src="{% static 'hyperkitty/libs/jquery.hotkeys.js' %}" />
-    <script type="text/javascript" src="{% static 'django-mailman3/js/main.js' %}" />
-    <script type="text/javascript" src="{% static 'hyperkitty/js/hyperkitty-common.js' %}" />
-    <script type="text/javascript" src="{% static 'hyperkitty/js/hyperkitty-index.js' %}" />
-    <script type="text/javascript" src="{% static 'hyperkitty/js/hyperkitty-overview.js' %}" />
-    <script type="text/javascript" src="{% static 'hyperkitty/js/hyperkitty-thread.js' %}" />
-    <script type="text/javascript" src="{% static 'hyperkitty/js/hyperkitty-userprofile.js' %}" />
+    <script type="text/javascript" src="{% static 'hyperkitty/libs/popper/popper.min.js' %}" ></script>
+    <script type="text/javascript" src="{% static 'hyperkitty/libs/bootstrap/javascripts/bootstrap.min.js' %}" ></script>
+    <script type="text/javascript" src="{% static 'hyperkitty/libs/mousetrap/mousetrap.min.js' %}" ></script>
+    <script type="text/javascript" src="{% static 'hyperkitty/libs/jquery.expander.js' %}" ></script>
+    <script type="text/javascript" src="{% static 'hyperkitty/libs/d3.v2.min.js' %}" ></script>
+    <script type="text/javascript" src="{% static 'hyperkitty/libs/jquery.hotkeys.js' %}" ></script>
+    <script type="text/javascript" src="{% static 'django-mailman3/js/main.js' %}" ></script>
+    <script type="text/javascript" src="{% static 'hyperkitty/js/hyperkitty-common.js' %}" ></script>
+    <script type="text/javascript" src="{% static 'hyperkitty/js/hyperkitty-index.js' %}" ></script>
+    <script type="text/javascript" src="{% static 'hyperkitty/js/hyperkitty-overview.js' %}" ></script>
+    <script type="text/javascript" src="{% static 'hyperkitty/js/hyperkitty-thread.js' %}" ></script>
+    <script type="text/javascript" src="{% static 'hyperkitty/js/hyperkitty-userprofile.js' %}" ></script>
     {% endcompress %}
     {% block additionaljs %} {% endblock %}