[Pkg-mailman-hackers] Bug#1031928: python3-django-hyperkitty: Javascript not loaded because of HTML error

[Pierre-Elliott Bécue]

Considering the version of django-compressor in bookworm, I think this
bug can be closed.

Feel free to reopen if I'm wrong.

James Addison <jay at jp-hosting.net> wrote on 04/03/2023 at 13:21:34+0100:

> Package: python3-django-hyperkitty
> Followup-For: Bug #1031928
> X-Debbugs-Cc: hjp at hjp.at
>
>> Can I change the severity of the bug?
>
> You should be able to do that, yes: by placing BTS (bug tracking system)
> control commands (as 'pseudoheaders') at the start of your email messages to
> bug threads: https://www.debian.org/Bugs/Reporting#additionalpseudoheaders
>
>> > Would you be willing to send your patch to the upstream hyperkitty project[1]
>> > as well?  (likely as a merge request on their GitLab instance)
>
>> Sure, but it seems to be fixed in upstream already, presumably because
>> they use a significantly newer version of django-compressor (4.3.1
>> instead of 2.4). The newer version of django-compressor reformats
>> <script .. /> to <script ..></script> even if COMPRESS_ENABLED = False.
>
> Fair point.. hmm.  Ideally we'd want test coverage to ensure that it doesn't
> happen again, though.
>
> The upstream codebase does appear to assert on the contents[1] of the HTML
> response in some cases; something similar could work as a regression test
> for this bug.
>
> [1] - https://gitlab.com/mailman/hyperkitty/-/blob/aae84b89184b9ae048ca693d332b7478f8734d4e/hyperkitty/tests/views/test_index.py#L214-220
>
> _______________________________________________
> Pkg-mailman-hackers mailing list
> Pkg-mailman-hackers at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-mailman-hackers

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 853 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-mailman-hackers/attachments/20240317/165afc08/attachment.sig>