Bug#886578: mate-user-share FTCBFS: wrongly uses pkg-config
Helmut Grohne
helmut at subdivi.de
Sun Jan 7 19:33:54 UTC 2018
Source: mate-user-share
Version: 1.18.0-1.1
Tags: patch upstream
User: helmutg at debian.org
Usertags: rebootstrap
mate-user-share fails to cross build from source, because it wrongly
uses pkg-config. The attached patch fixes all the issues and makes it
cross build. Let me briefly discuss the hunks:
* Using AC_PATH_PROG results in not considering $ac_tool_prefix. This
generally breaks cross compilation. AC_PATH_TOOL is an improvement,
but PKG_PROG_PKG_CONFIG is the correct upstream macro to use.
* Using PKG_CHECK_MODULES inside an if can break later PKG_CHECK_MODULES
relying on the AC_REQUIRE part being run. AS_IF ensures that
requirements are run before the condition.
* Running a bare pkg-config again misses $ac_tool_prefix.
Helmut
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cross.patch
Type: text/x-diff
Size: 1331 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-mate-team/attachments/20180107/edc1168c/attachment.patch>
More information about the pkg-mate-team
mailing list