eom Patches

[Mike Gabriel]

Hi Vangelis,

On  Mi 22 Jan 2014 17:41:49 CET, Vangelis Mouhtsis wrote:

> [...]

I posted my feedback on IRC, but I just thought it might be good to  
have it copied to the ML, as well:

1. debian/changelog:
10:35 < sunweaver> gnugr: this is about me becoming picky now...
10:35 < sunweaver> I prefer "Initial release. (Closes: #730320)"  
ending with a dot/full-stop.
10:35 < sunweaver> so, what I do is...
10:35 < sunweaver> "Initial  release. (Closes:  #730320).
10:36 < sunweaver> Actually, all my changelog entries end with a full-stop.
10:36 < sunweaver> full-stop (BE) is period in (American English) I  
just learned

2. debian/control:
10:37 < sunweaver> gnugr: you are right, the Maintainer field of  
package eom lacks the e-Mail address.
10:37 < sunweaver> please add it.

3. debian/watch:
10:38 < sunweaver> for the eom/debian/watch file, we have to do some  
name mangling...
10:39 < sunweaver> the tarball is called  
mate-image-viewer-<version>.tar.gz whereas the Debian package's orig  
tarbal is called eom_<version>.orig.tar.gz
10:40 < sunweaver> so we have to rename map between mate-image-viewer  
and eom when using the watch file to obtain the upstream tarbal.
10:41 < sunweaver> check the marco/debian/watch file for an example  
how to do this filename mangling:
http://anonscm.debian.org/gitweb/?p=pkg-mate/marco.git;a=blobdiff;f=debian/watch;h=0e6732154e90a43694c56a6c9eb60888d4a43cea;hp=8b4fbd6c5c670ac0cecad44bfcaa25baa4db3953;hb=9fc132d4f1ad2b900e0bacc7681c0f5eb35522b4;hpb=165e668f2526bb7c1302c546fe7a10521e1d119a

4. debian/copyright:
10:44 < sunweaver> In eom/debian/copyright: we should put new and old  
upstream name in Upstream-Name: field.
10:44 < sunweaver> check marco/debian/copyright for an example.

Good work + Please fix! + Greets,
Mike


-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digitale PGP-Signatur
URL: <http://lists.alioth.debian.org/pipermail/pkg-mate-team/attachments/20140124/b936c2ad/attachment.sig>