mate-terminal patches

John Paul Adrian Glaubitz glaubitz at physik.fu-berlin.de
Sat Feb 22 20:12:12 UTC 2014


Hola Wences!

On 02/22/2014 08:56 PM, Wences René Arana Fuentes wrote:
> -               yelp-tools
> +               yelp-tools,
> +	       mate-doc-utils,
> +	       mate-doc-utils-gnome,
> +	       python-all (>= 2.6)

Please make sure you have the same indentation/tab stops when adding
indented lines.

> +License: GLP-3+
> +

I see that you fix this in a later patch. I think it's better to just
add your previous commit by using "git rebase", see [1]. You should
probably practice a bit before you use "git rebase" because it might
be a bit unusual at first try, but it's very handy once you got
the hack of it!

Did you also perform a detailed lintian run at the end? Thus, running
"lintian -i -E -I --pedantic mate-terminal_1.6.2-1_amd64.changes"
after building the package. lintian will find anything that's wrong
with the package.

Thanks a lot for your patch set!

Cheers,

Adrian

> [1]
http://stackoverflow.com/questions/1186535/how-to-modify-a-specified-commit

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



More information about the pkg-mate-team mailing list