mozo patches

[Mike Gabriel]

Hi Adrian, hi Vangelis,

On  Mi 09 Apr 2014 11:23:37 CEST, John Paul Adrian Glaubitz wrote:

> On 04/09/2014 10:31 AM, Vangelis Mouhtsis wrote:
>> Please review my patches for mozo and ping me if i can push them.
>
> Looks very good to me.
>
> But shouldn't the DEB_CONFIGURE_SCRIPT variable in the rules file be
> uncommented again?
>
>  include /usr/share/cdbs/1/rules/debhelper.mk
> -include /usr/share/cdbs/1/rules/autoreconf.mk
>  include /usr/share/cdbs/1/class/autotools.mk
>
>  DEB_DH_INSTALL_ARGS += --list-missing
>
> -# FIXME: for 1.8.x we will return back to using autogen.sh
>  #DEB_CONFIGURE_SCRIPT := ./autogen.sh

Yes, it should be uncommented...

> Also, I recommend creating the new changelog entry in the last stage.
> This way you avoid spreading changes to the changelog over three
> patches.

Mea culpa. I agree, that we actually should create the changelog on  
the commit before uploading.

Thus, the maintainer you finally uploads the package becomes  
responsible for the changelog creation and editing.

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digitale PGP-Signatur
URL: <http://lists.alioth.debian.org/pipermail/pkg-mate-team/attachments/20140410/1c26e688/attachment.sig>