patches for pluma-1.8.0

Mike Gabriel mike.gabriel at das-netzwerkteam.de
Thu Apr 10 17:36:11 UTC 2014


Hi Vangelis,

On  Do 10 Apr 2014 09:58:12 CEST, Vangelis Mouhtsis wrote:

> Mike hi,
> Please review them and guide me what to do next.
>
> greets
> gnugr

> ---
>  debian/control |  2 +-
>  debian/rules   | 14 ++++++++------
>  2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/debian/control b/debian/control
> index 66d52bc..50c95ae 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -20,7 +20,7 @@ Build-Depends: debhelper (>= 9),
>                 libgtksourceview2.0-dev,
>                 libx11-dev,
>                 mate-common,
-               dh-autoreconf,
+               autogen.sh,

^^^^^ what is this ??? ^^^^

autogen.sh is a script contained in every MATE project source tarball.  
It it not a package.

Every package's autogen.sh script requires mate-common as build dependency.

Also, for this patch, removin dh-autoreconf from build deps is ok. But  
don't add autogen.sh.

>                 python-dev,
>                 python-gobject-2-dev,
>                 python-gtk2-dev,
>  override_dh_auto_configure:
> -	dh_auto_configure -- \
> -		--libexecdir=/usr/lib/ \
> -		--enable-python \
> -		--with-gtk=2.0
> +        # upstream tarball is without configure. autogen.sh will create it
> +        NOCONFIGURE=1 ./autogen.sh
> +	    dh_auto_configure -- \
> +		        --libexecdir=/usr/lib/ \
> +		        --enable-python \
> +		        --with-gtk=2.0
>   override_dh_auto_test:
>  	DEB_BUILD_OPTIONS=nocheck dh_auto_test

The indentation is faulty. Make sure that tabs and whitespaces are  
correct. Not that Makefiles (and debian/rules basically is a Makefile)  
use tabs for identifying commands sequences for a certain make target.

I personally use mcedit for working on Makefiles (or debian/rules) as  
it has some nice whitespace highlighting. Any other editor that shows  
tabs and trailing spaces at EOL is fine, too.

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digitale PGP-Signatur
URL: <http://lists.alioth.debian.org/pipermail/pkg-mate-team/attachments/20140410/f5cb2ff2/attachment.sig>


More information about the pkg-mate-team mailing list