Bug#773338: mate-system-tools: fix implicit conversion of bsearch to pointer

[Logan Rosen]

Package: mate-system-tools
Version: 1.8.1+dfsg1-1
Severity: important
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu vivid ubuntu-patch

Dear Maintainer,

As you can see from the build log checks [1], there is an issue on a number of architectures for mate-system-tools where bsearch is implicitly converted to a pointer without a cast. This can cause a segfault on some architectures, and Ubuntu fails to build packages that have this problem. [2]

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/1004_include-cstdlib.patch: Include <stdlib.h> in
    connection.c to fix implicit declaration and conversion to pointer of
    bsearch.

Thanks for considering the patch.

Logan Rosen

[1] https://qa.debian.org/bls/packages/m/mate-system-tools.html
[2] https://wiki.debian.org/ImplicitPointerConversions

-- System Information:
Debian Release: jessie/sid
  APT prefers vivid-updates
  APT policy: (500, 'vivid-updates'), (500, 'vivid-security'), (500, 'vivid'), (100, 'vivid-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-25-generic (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mate-system-tools_1.8.1+dfsg1-1ubuntu1.debdiff
Type: text/x-diff
Size: 1032 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-mate-team/attachments/20141217/d1e0bd73/attachment-0001.diff>