[Pkg-matrix-maintainers] Bug#922098: RFE: matrix-synapse.service should have ExecReload

[Willem Mulder]

control: tags -1 +patch

Hi,

On Thu, 11 Apr 2019 22:29:29 +0200 Jörg Sommer <joerg at jo-so.de> wrote:
> On Tue, 12 Feb 2019 01:50:49 +0100 Damjan Georgievski
<gdamjan at gmail.com> wrote:
> > Package: matrix-synapse
> > Version: 0.99.0-1
> >
> > […]
>
> But Synapse doesn't reload the config on SIGHUP, esp. it does not reload
> the `tls_fingerprints` which is needed when certbot updates the TLS key.
>

It's not, see homeserver.yaml:

> # Synapse automatically adds the fingerprint of its own certificate
> # to the list. So if federation traffic is handled directly by synapse
> # then no modification to the list is required.

I've attached a debdiff that resolves this bug.

Kind regards,

Willem Mulder

-------------- next part --------------
diff -Nru matrix-synapse-0.99.2/debian/changelog matrix-synapse-0.99.2/debian/changelog
--- matrix-synapse-0.99.2/debian/changelog	2019-05-03 22:26:41.000000000 +0200
+++ matrix-synapse-0.99.2/debian/changelog	2019-05-10 11:35:18.000000000 +0200
@@ -1,3 +1,10 @@
+matrix-synapse (0.99.2-5.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Add reload action to systemd service to be able to reload certificates.
+
+ -- Willem Mulder <14mRh4X0r at gmail.com>  Fri, 10 May 2019 11:35:18 +0200
+
 matrix-synapse (0.99.2-5) unstable; urgency=high
 
   * Security updates backported from 0.99.3:
diff -Nru matrix-synapse-0.99.2/debian/matrix-synapse.service matrix-synapse-0.99.2/debian/matrix-synapse.service
--- matrix-synapse-0.99.2/debian/matrix-synapse.service	2019-05-03 22:26:41.000000000 +0200
+++ matrix-synapse-0.99.2/debian/matrix-synapse.service	2019-05-10 11:34:46.000000000 +0200
@@ -9,6 +9,7 @@
 EnvironmentFile=/etc/default/matrix-synapse
 ExecStartPre=/usr/bin/python3 -m synapse.app.homeserver --config-path=/etc/matrix-synapse/homeserver.yaml --config-path=/etc/matrix-synapse/conf.d/ --generate-keys
 ExecStart=/usr/bin/python3 -m synapse.app.homeserver --config-path=/etc/matrix-synapse/homeserver.yaml --config-path=/etc/matrix-synapse/conf.d/
+ExecReload=/bin/kill -HUP $MAINPID
 Restart=on-failure
 RestartSec=3
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-matrix-maintainers/attachments/20190510/bdfb391c/attachment.sig>