[Pkg-matrix-maintainers] Bug#960106: matrix-synapse: synapse_port_db script does not know about /etc/matrix-synapse/conf.d

[Nikolay Shaplov]

Package: matrix-synapse
Version: 1.12.3-1~bpo10+1
Severity: normal


Hi! I am migrating synaps from sqlite into postgres, using
upstream manual: 
https://github.com/matrix-org/synapse/blob/master/docs/postgres.md

When I ran synapse_port_db script

/usr/bin/synapse_port_db --sqlite-database homeserver.db  --postgres-config  /etc/matrix-synapse/homeserver-postgres.yaml

I got an error

Traceback (most recent call last):
  File "/usr/bin/synapse_port_db", line 1019, in <module>
    config.parse_config_dict(hs_config, "", "")
  File "/usr/lib/python3/dist-packages/synapse/config/_base.py", line 661, in parse_config_dict
    data_dir_path=data_dir_path,
  File "/usr/lib/python3/dist-packages/synapse/config/_base.py", line 276, in invoke_all
    res[name] = getattr(config, func_name)(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/synapse/config/server.py", line 64, in read_config
    self.server_name = config["server_name"]
KeyError: 'server_name'


I guess this is because of server_name option, that has been moved to
/etc/matrix-synapse/conf.d/server_name.yaml whide debianisation of
synapse, and synapse_port_db script did not know that it should look
for config parts there.

I copied server_name options to the homeserver-postgres.yaml file
and thus managed to run the script as it should.

I guess you should patch synapse_port_db script that it would
take options from conf.d as synaps server do.



-- System Information:
Debian Release: 10.3
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-6-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages matrix-synapse depends on:
ii  adduser                    3.118
ii  debconf [debconf-2.0]      1.5.71
ii  libjs-jquery               3.3.1~dfsg-3
ii  libpython3-stdlib          3.7.3-1
ii  lsb-base                   10.2019051400
ii  python3                    3.7.3-1
ii  python3-attr               18.2.0-1
ii  python3-bcrypt             3.1.6-1
ii  python3-bleach             3.1.2-0+deb10u1
ii  python3-canonicaljson      1.1.4-2
ii  python3-daemonize          2.4.7-2
ii  python3-distutils          3.7.3-1
ii  python3-frozendict         1.2-1
ii  python3-idna               2.6-1
ii  python3-jinja2             2.10-2
ii  python3-jsonschema         2.6.0-4
ii  python3-lxml               4.3.2-1
ii  python3-msgpack            0.5.6-1+b1
ii  python3-nacl               1.3.0-2
ii  python3-netaddr            0.7.19-1
ii  python3-openssl            19.0.0-1
ii  python3-phonenumbers       8.9.10-1
ii  python3-pil                5.4.1-2+deb10u1
ii  python3-prometheus-client  0.6.0-1
ii  python3-pyasn1             0.4.2-3
ii  python3-pyasn1-modules     0.2.1-0.2
ii  python3-pymacaroons        0.13.0-2
ii  python3-service-identity   18.1.0-5~bpo10+1
ii  python3-signedjson         1.1.0-1~bpo10+1
ii  python3-six                1.12.0-1
ii  python3-sortedcontainers   2.0.4-1
ii  python3-systemd            234-2+b1
ii  python3-treq               18.6.0-0.1
ii  python3-twisted            18.9.0-8~bpo10+1
ii  python3-typing-extensions  3.7.4.1-1~bpo10+1
ii  python3-unpaddedbase64     1.1.0-4
ii  python3-yaml               3.13-2

Versions of packages matrix-synapse recommends:
ii  python3-psycopg2  2.7.7-1

Versions of packages matrix-synapse suggests:
pn  python3-txacme  <none>

-- Configuration Files:
/etc/matrix-synapse/homeserver.yaml changed [not included]

-- debconf information excluded