[Pkg-matrix-maintainers] Bug#1057648: synadm: Add bash completion script to synadm

[Nicolas Peugnet]

Package: synadm
Version: 0.43.1-1
Severity: wishlist
Tags: patch

Dear Maintainer,

In case you didn't see, I made a merge request on salsa [1] to generate
the bash completion script from Click and to add it to the binary
package.
I'm trying to also send the patch via reportbug, but as this is the
first time I am trying to do it I am not entirely sure to succeed.

[1] https://salsa.debian.org/matrix-team/synadm/-/merge_requests/1


-- System Information:
Debian Release: 12.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-13-amd64 (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages synadm depends on:
ii  python3                     3.11.2-1+b1
pn  python3-click               <none>
pn  python3-click-option-group  <none>
pn  python3-dnspython           <none>
ii  python3-requests            2.28.1+dfsg-1
pn  python3-tabulate            <none>
ii  python3-yaml                6.0-3+b2

synadm recommends no packages.

synadm suggests no packages.
-------------- next part --------------
>From 6bfcb55140b28ba438292e70bea5df8525bca9d6 Mon Sep 17 00:00:00 2001
From: Nicolas Peugnet <nicolas at club1.fr>
Date: Sun, 3 Dec 2023 17:16:17 +0100
Subject: [PATCH] add click generated bash-completion script

---
 debian/clean                       |  1 +
 debian/control                     |  1 +
 debian/patches/0001-add-main.patch | 12 ++++++++++++
 debian/patches/series              |  1 +
 debian/rules                       |  4 +++-
 5 files changed, 18 insertions(+), 1 deletion(-)
 create mode 100644 debian/clean
 create mode 100644 debian/patches/0001-add-main.patch
 create mode 100644 debian/patches/series

diff --git a/debian/clean b/debian/clean
new file mode 100644
index 0000000..5d84c6b
--- /dev/null
+++ b/debian/clean
@@ -0,0 +1 @@
+debian/synadm.bash-completion
diff --git a/debian/control b/debian/control
index 86e33e4..2a07e89 100644
--- a/debian/control
+++ b/debian/control
@@ -5,6 +5,7 @@ Maintainer: Matrix Packaging Team <pkg-matrix-maintainers at lists.alioth.debian.or
 Uploaders: Sebastien Badia <sbadia at debian.org>
 Build-Depends: debhelper-compat (= 13),
                dh-python,
+               bash-completion,
                python3-all,
                python3-click,
                python3-click-option-group,
diff --git a/debian/patches/0001-add-main.patch b/debian/patches/0001-add-main.patch
new file mode 100644
index 0000000..7813d1c
--- /dev/null
+++ b/debian/patches/0001-add-main.patch
@@ -0,0 +1,12 @@
+Description: Add __main__.py to ba able to run package
+Author: Nicolas Peugnet <nicolas at club1.fr>
+Forwarded: https://github.com/JOJ0/synadm/pull/138
+Last-Update: 2023-11-20
+---
+
+--- /dev/null
++++ synadm-0.43.1/synadm/__main__.py
+@@ -0,0 +1,3 @@
++from synadm.cli import root
++
++root()
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..bba785d
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+0001-add-main.patch
diff --git a/debian/rules b/debian/rules
index d88e477..7212ef6 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,5 +1,7 @@
 #! /usr/bin/make -f
 
 export PYBUILD_NAME=synadm
+export PYBUILD_AFTER_BUILD=_SYNADM_COMPLETE=bash_source {interpreter} {build_dir}/synadm > debian/synadm.bash-completion
+
 %:
-	dh $@ --with python3 --buildsystem=pybuild
+	dh $@ --with python3 --buildsystem=pybuild --with=bash-completion
-- 
2.39.2