[Pkg-middleware-maintainers] Bug#772188: avis: bashism in /bin/sh script

Cameron Norman camerontnorman at gmail.com
Sat Dec 6 06:11:04 UTC 2014


On Sat, 06 Dec 2014 01:14:12 +0100 Raphael Geissert 
<geissert at debian.org> wrote:
 > Package: avis
 > Severity: serious
 > Version: 1.2.2-3
 > User: debian-release at lists.debian.org
 > Usertags: goal-dash
 >
 > Hi,
 >
 > I've ran checkbashisms (from the 'devscripts' package) over the whole
 > archive and I found that your package has a /bin/sh script that uses 
a
 > "bashism".
 >
 > checkbashisms' output:
 > > possible bashism in ./usr/sbin/avisd line 24 ($'...' should be 
"$(printf
 > > '...')"):
 > >   local NL=$'\x0a'
 >
 >
 > Not using bash (or a Debian Policy compliant shell interpreter that 
doesn't
 > provide such an extra feature) as /bin/sh is likely to lead to 
errors or
 > unexpected behaviours. Please be aware that dash is the default 
/bin/sh.
 >
 > Please closely examine the above output and the script, and determine
 > what the proper severity of the bug is, and adjust it accordingly. If
 > it's important or greater please hurry to get this fixed for jessie.
 >
 > Hints about how to fix bashisms can be found at:
 > https://wiki.ubuntu.com/DashAsBinSh

I have attached a patch which avoids this bashism. Please apply it to 
fix this RC bug. It is very non-intrusive.

Gratzie,
--
Cameron Norman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-middleware-maintainers/attachments/20141205/f796cf4f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: avis-no-bashisms.patch
Type: text/x-patch
Size: 1172 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-middleware-maintainers/attachments/20141205/f796cf4f/attachment.bin>


More information about the Pkg-middleware-maintainers mailing list