[Pkg-monitoring-maintainers] Bug#1104576: mon: preinst fails, calls adduser without Pre-Depend-ing on it

[Chris Hofstaedtler]

Package: mon
Version: 1.4.1-1
Severity: serious

Your package has a preinst maintainer script, calling adduser. At the same
time, your package Depends: adduser, but does not Pre-Depends: adduser.
Installing your package fails when adduser is not yet configured.

Reproducer:

$ mmdebstrap --variant=essential --include=mon unstable /dev/null
...
Selecting previously unselected package mon-client.
Preparing to unpack .../22-mon-client_1.2.0-3_all.deb ...
Unpacking mon-client (1.2.0-3) ...
Selecting previously unselected package mon.
Preparing to unpack .../23-mon_1.4.1-1_arm64.deb ...
Creating user 'mon' ... warn: `/etc/adduser.conf' does not exist. Using defaults.
Insecure $ENV{PATH} while running with -T switch at /usr/share/perl5/Debian/AdduserLogging.pm line 161.
dpkg: error processing archive /tmp/apt-dpkg-install-eLquvp/23-mon_1.4.1-1_arm64.deb (--unpack):
 new mon package pre-installation script subprocess returned error exit status 25
Errors were encountered while processing:
 /tmp/apt-dpkg-install-eLquvp/23-mon_1.4.1-1_arm64.deb


You may consider replacing adduser with a sysusers fragment, see
https://manpages.debian.org/unstable/debhelper/dh_installsysusers.1.en.html

Otherwise, please Pre-Depend on adduser.

Best,
Chris