[Pkg-mozext-maintainers] RFS: addressbooks-sync-extension

[Michael Fladischer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Benjamin Drung, 2010-12-03 15:15:
> 1) The name: Do we need "-extension" in the source name? Is there an
> other project which could conflict? What's with the upstream name
> "addressbooks-synchronizer"?

I renamed it. My idea was to distinguish it from other similar projects
but as "-extension" has no link to Mozilla software either I agree with
dropping it and using the full upstream name.

> 2) Please add ${xpi:Depends} to Depends (refer to mozilla-devscripts
> 0.25)

Done.

> 3) Please mention the upstream names for Icedove and Iceape (at least in
> the long description)

Done. But whom would this help? Ubuntu?

> 4) Some trailing spaces. Run 'wrap-and-sort' (from ubuntu-dev-tools in
> experimental) to get rid of them.

Done. Thanks for pointing out to this collection of nifty tools :-)

> 5) Change "dh ... $@" to "dh $@ ..." in debian/rules (check debhelper
> changelog)

Done.

> 6) Don't rely on the installation directory. The installation directory
> depends on the version of mozilla-devscripts. You have to either specify
> the location explicitly or (better) use install-xpi with
> --remove-license-files.

Done. [1] mentions the override_dh_auto_clean target. Is this necessary
to override this one even when I specified "dh $@ --with xul-ext
- --buildsystem=xul_ext"?

[1] http://wiki.debian.org/mozilla-devscripts

Changes have been pushed (repo has moved to
".../addressbooks-synchronizer.git" accordingly) and a new Package has
been uploaded to mentors.d.n.

Thanks for the review,
- -- 
Michael Fladischer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEUEARECAAYFAkz5EL8ACgkQeJ3z1zFMUGZpwwCY+01TMJtZcM3yHj20Ljq8Kug9
wQCfYgp1O0UhWxbL5zoHRmDj5xC5oeg=
=8unk
-----END PGP SIGNATURE-----