[Pkg-mozext-maintainers] flashblock package

[Ximin Luo]

On 05/12/11 22:12, Alexander GQ Gerasiov wrote:
> Hi.
> 
> I found that you've done some strange changes to git tree of flashblock
> package.
> 
> You have created new tree of commits with very strange history. This is
> wrong.
> 
> I had to change history in public repository to make it sequential.
> 
> Please, next time use git-buildpackage correctly and consult me in case
> of troubles.
> 
> Some simple rules:
> * import new upstream into tree with git-import-orig
> * one commit per change
> * first line in commit log is a description for inclusion into
>   debian/changelog
> * do not commit debian/changelog until you release package
> * generate debian/changelog with git-dch
> 

Hi Alex, thanks for this, but in the future could you be more specific about
what was wrong, so people can avoid making the same mistakes in future? Also
telling the tree SHA1 of the master branch before/after your edits would be
nice (git cat-file -p master) - they should be the same, unless you have an
explanation for why they should be different.

Also in commit 81881638e5274bb02e4584579c684cd6026ed4a3, you forgot to
`xpi-unpack` the xpi - you added the file chrome/flashblock.jar and removed the
directory chrome/flashblock.jar!/. Since you're editing the history already, do
you mind fixing this and doing another forced push?

X

-- 
GPG: 4096R/5FBBDBCE
https://github.com/infinity0
https://bitbucket.org/infinity0
https://launchpad.net/~infinity0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozext-maintainers/attachments/20111205/7650e8fe/attachment.pgp>