[Pkg-mozext-maintainers] RFS: httpfox - extension for the Iceweasel/Firefox web browser

[Michael Fladischer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Mahyuddin Susanto, 2011-01-07 17:45:
> I am looking for a sponsor for my package "httpfox".

IANADDY, but here is my review of your package:

debian/control:
- - If you update Build-Depends to "mozilla-devscripts (>= 0.22~)", you
  could simplify debian/rules to a certain degree.
- - Architecture should be "all" because your package does not contain
  any native code.
- - You should add "${xpi:Depends}" to Depends.
- - Description: There are two lintian warnings in this section. Please
  add one trailing whitespace to each item in the bullet list on the
  end and check line lengths (line 19 & 22).
  The short description is also very vague and gives no hint on the
  purpose of the package. Maybe something like "HTTP traffic analyzing
  Iceweasel/Firefox extension" would be better.

debian/copyright:
- - DEP5 r153 has been released and it would be nice to have this file
  already compliant to this version. You could take a look at [0]
  for an example on what to change for DEP5 r153 and on how the
  structure of a DEP5 copyright file should look like.
- - The "©" characters in the Copyright fields are not necessary.
- - I'm pretty sure that the initial part of the GPL-2+ is missing ("This
  program is free software; ...").

debian/rules:
- - See [1] to simplify this file (bump mozilla-devscripts b-dependency
  in debian/control).
- - Removing the license file is not necessary. Instead use the "-r"
  option for "install-xpi" in the "override_dh_auto_install" target.
  Doing so will allow you to drop "override_dh_auto_clean" and
  "override_dh_auto_build". Example at [2].

debian/watch:
- - Add " debian xpi-repack" to the seond line of this file to
automatically repack the downloaded .xpi as a tar.bz2 (see "man
xpi-repack" for details).

[0]
http://svn.debian.org/viewsvn/python-modules/packages/django-picklefield/tags/0.1.9-1/debian/copyright?view=markup
[1] http://wiki.debian.org/mozilla-devscripts
[2]
http://git.debian.org/?p=pkg-mozext/greasefire.git;a=blob_plain;f=debian/rules;hb=HEAD

HTH,
- -- 
Michael Fladischer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0nUdQACgkQeJ3z1zFMUGapxQCfZG7+gzNnwb3h5+lXGyEk8bUj
D3IAnjzUJmtwWiTHNO6/lMGJydcFtF0S
=yuOU
-----END PGP SIGNATURE-----