[Pkg-mozext-maintainers] Bug#623970: ITP: xul-ext-cookie-monster -- please package Iceweasel Cookie Monster extension
lunar at debian.org
Fri Sep 9 13:02:38 UTC 2011
On Fri, Sep 09, 2011 at 12:28:56PM +0200, Fabrizio Regalli wrote:
> > I'm no DM nor DD yet. However, I already partly reviewed your package
> > and asked a few questions, unanswered as of today. See the
> > aforementioned email.
> I don't replied because all task request in your mail are already done.
> (apart the pristine-tar, added just now)
> This package is on git from 2011-04-28: if there were all sorts of
> problems, I could solve them, don't you believe ?
Here is my review:
* Files in pristine-tar are wrongly named
Trying to build the package with `git-buildpackage
--git-pristine-tar` fails with:
pristine-tar: git show refs/heads/pristine-tar:cookie-monster_1.0.5.orig.tar.gz.delta failed
Indeed. The files are currently named
* dpkg-source: error: unrepresentable changes to source
As upstream does not ship .tar.gz (or .tar.bz2 for that matter) that
Debian could directly use, we need to create a .orig.tar.gz from
So we are free to fiddle with upstream source in order to get the
files as close as we would like upstream to ship them. I then
strongly advocate to have a .orig.tar.gz where cookiemonster.jar
That will also remove the useless patch in debian/patches and ease
future reviews of upstream changes
* Package description could be improved
The package description does not mention that cookie-monster is
an extension for Firefox/Iceweasel. Please note that
volunteers subscribed to debian-l10-english at l.d.o can help to
write better (english) package descriptions.
* Package is missing a README.source
Even if it's not mandatory, the package is really missing a
README.source. It is supposed to be under the pkg-mozext umbrella,
so other member of that team should be able to upload the package
if the need arises.
Things that ought to be documented are at least: git-buildpackage
usage, pristine-tar usage, the upstream-changelog file (why, what and
how to update it).
* Vcs-* should be updated
Vcs-* field in debian/control should be updated to the new URIs.
* Inaccurate copyright file
The copyright file that gets installed in
/usr/share/doc/xul-ext-cookie-monster/copyright is inaccurate,
as the MPL license is not copied to the same directory.
The .jar and copyright issues really are blockers to me.
Jérémy Bobbio .''`.
jeremy.bobbio at irq7.fr : : : lunar at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Pkg-mozext-maintainers