[Pkg-mozext-maintainers] RFS: https-everywhere

Paul Wise pabs at debian.org
Sun Sep 25 14:20:39 UTC 2011


On Sun, 2011-09-25 at 10:20 -0300, Rogério Brito wrote:

> Thanks for the upload. Surprised that you didn't even have any
> criticism regarding the packaging. It seems that I may be doing
> something right. :-) 

Some feedback:

You might want dh --parallel, I don't imagine the package takes long to
build though.

I wonder why you use bzip2 compression in the deb. I doubt that is
needed. If you really care to have something better than gzip, xz is
better than bzip2 in many aspects.

I found the extensive wrapping in debian/control interesting.

Bonus points to upstream for including the preferred form for
modification of the logo within the source package, and for using free
software (GIMP) to produce it. Two of the other images were produced in
Photoshop though :(

Could you include add nm.debian.org, db.debian.org and wiki.debian.org
to the list of HTTPS-preferred websites? I guess that should be
forwarded upstream too.

The upstream Changelog looks more like what I would expect in a NEWS
file, mainly because I read the GNU coding standards early.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 933 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozext-maintainers/attachments/20110925/ef826a85/attachment.pgp>


More information about the Pkg-mozext-maintainers mailing list