[Pkg-mozext-maintainers] Bug#695925: xul-ext-sieve - Edit filter does not work at all

[Dominik George]

Control: tags -1 + patch pending - moreinfo

Hi,

@ Michael: *Please* Cc *any* parties that seem to be working on the issue 
in follow-ups - knowing that you already have a patch would have saved 
quite a bit of work! Thank you!

Anyway, attached is my version of a patch. It builds 
xul-ext-sieve_0.1.14-1.1 and does what Mozilla themselves seem to do to 
fix such issues (c.f. 
https://bugzilla.mozilla.org/show_bug.cgi?id=520237).

Please note that the BTS breaks diff files in transit 
(http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695627).

-nik

-- 
* mirabilos is handling my post-1990 smartphone *
<mirabilos> Aaah, it vibrates! Wherefor art thou, daemonic device??

PGP fingerprint: 2086 9A4B E67D 1DCD FFF6  F6C1 59FC 8E1D 6F2A 8001
-------------- next part --------------
diff -Nru sieve-extension-0.1.14/debian/changelog sieve-extension-0.1.14/debian/changelog
--- sieve-extension-0.1.14/debian/changelog	2012-03-09 10:07:29.000000000 +0100
+++ sieve-extension-0.1.14/debian/changelog	2012-12-17 15:02:06.000000000 +0100
@@ -1,3 +1,12 @@
+sieve-extension (0.1.14-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fix "Edit filters" button which caused a JavaScript error
+    and the button to be useless, reported by Bastian Blank
+    (Closes: #695925)
+
+ -- Dominik George <nik at naturalnet.de>  Mon, 17 Dec 2012 15:00:58 +0100
+
 sieve-extension (0.1.14-1) unstable; urgency=low
 
   * New upstream release.
diff -Nru sieve-extension-0.1.14/debian/patches/series sieve-extension-0.1.14/debian/patches/series
--- sieve-extension-0.1.14/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ sieve-extension-0.1.14/debian/patches/series	2012-12-17 14:53:31.000000000 +0100
@@ -0,0 +1 @@
+tabmail.patch
diff -Nru sieve-extension-0.1.14/debian/patches/tabmail.patch sieve-extension-0.1.14/debian/patches/tabmail.patch
--- sieve-extension-0.1.14/debian/patches/tabmail.patch	1970-01-01 01:00:00.000000000 +0100
+++ sieve-extension-0.1.14/debian/patches/tabmail.patch	2012-12-17 15:00:51.000000000 +0100
@@ -0,0 +1,25 @@
+Author: Dominik George <nik at naturalnet.de>
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695925
+Description: Fix "Edit filters" button in settings
+--- a/chrome/chromeFiles/content/SieveOverlay.js
++++ b/chrome/chromeFiles/content/SieveOverlay.js
+@@ -67,7 +67,18 @@
+     }
+   }
+   
+-  document.getElementById("tabmail").openTab("SieveExplorerTab", options);
++  let mail3PaneWindow = Components.classes["@mozilla.org/appshell/window-mediator;1"]
++                                  .getService(Components.interfaces.nsIWindowMediator)
++                                  .getMostRecentWindow("mail:3pane");
++  if (mail3PaneWindow) {
++   mail3PaneWindow.focus();
++   mail3PaneWindow.document.getElementById("tabmail").openTab("SieveExplorerTab", options);
++  } else {
++   window.openDialog("chrome://messenger/content/", "_blank",
++                     "chrome,dialog=no,all", null,
++                     { tabType: "SieveExplorerTab",
++                       tabParams: options });
++  }
+     
+   return;
+