[Pkg-mozext-maintainers] https-finder: membership please :)

Dmitry Smirnov onlyjob at member.fsf.org
Thu Nov 22 11:41:00 UTC 2012


On Thu, 22 Nov 2012 22:10:31 Benjamin Drung wrote:
> > > > > Do you know wrap-and-sort?
> > > > 
> > > > Now I know, thanks to your hint. :)
> > > 
> > > Good. May I ask you to run it?
> > 
> > Sorry, I don't like the change that it does.
> > If that's so important for you, I don't mind if you do it.
> 
> Why do you dislike the change? wrap-and-sort puts the ${...} variables
> at the end, because they can expand to everything and break the
> alphabetical order.
> 

Maybe it's a good thing as you say but I prefer variables in front...

Perhaps I need time to adopt a new tool as well.

But although the idea of wrap-and-sort is nice, the implementation is not:
there is no --dry-run mode and it silently touches debian/copyright file.
Verbose mode doesn't even show what does it do.

Also I like to keep packaging dependencies in first line followed by list of 
upstream dependencies. I like having debhelper as first dependency etc.

I hope I'm not too conservative...


> > > > > You can drop the comments from debian/rules and debian/watch.
> > > > 
> > > > I prefer to keep them. I specifically put those minimum comments
> > > > there as I think they are useful. We won't gain much by dropping few
> > > > lines...
> > > 
> > > We would gain a faster scanning of the content with less clutter. 25%
> > > or 33% less lines to read. The comments in debian/rules and
> > > debian/watch should explain special cases or stuff a random packager
> > > does not know.
> > 
> > Random packager may not remember where to look for help regarding
> > debian/watch file.
> 
> Really? Searching on the Internet for "debian/watch", gives
> http://wiki.debian.org/debian/watch/ as first result. This page points
> to uscan.

OK. I'm not that stubborn to protect this particular comment line. :)

Feel free to remove it if you like.

 
> > > DH_VERBOSE is documented in the man page of debhelper. It is not
> > > specific to your package.
> > 
> > Yes and I'd like to keep it commented in case someone (including myself)
> > needs to easily increase build verbosity.
> 
> Okay.

Thank you. I'm glad we can keep this one.

> 
> I have uploaded your package and tagged it in git after two
> small and hopefully uncontroversial changes.

Thank you very much for upload and for adding "${xpi:Breaks}" which I missed. 
I much appreciate you attention and care for this package.

All the best,
Dmitry.



More information about the Pkg-mozext-maintainers mailing list