[Pkg-mozext-maintainers] Review Initial packaging for Cryptocat

[Ximin Luo]

On 03/02/15 18:12, Daniel Kahn Gillmor wrote:
> On Tue 2015-02-03 11:08:49 -0500, u wrote:
>> However, I am still not completely done with the package, because now I
>> get different lintian errors:
>>
>> E: cryptocat source: source-is-missing chrome/content/data/js/lib/tinycon.js
>> E: cryptocat source: source-is-missing
>> chrome/content/data/js/lib/mousetrap.js
>> E: cryptocat source: source-is-missing
>> chrome/content/data/js/lib/jquery/jquery.js
>> E: cryptocat source: source-is-missing
>> chrome/content/data/js/lib/jquery/jquery.color.js
>>
>> From what I understand, this is due to the fact that these files are
>> minimized. Should I fix this by adding the debian/missing-sources
>> directory?
> 
> yep, this is probably a reasonable way to go.  Alternately, you could
> make sure that the source javascript is present in the debian archive
> separately, and just link to them separately.
> 
>> Also I do not completely understand why jquery.js still shows up in this
>> list either, as it is symlinked now.
> 
> the warnings are warnings from the source package -- the linkage happens
> in the binary package, right?
> 
> There are two approaches to fixing this: one is to re-pack the upstream
> source package so that it doesn't include jquery at all; the other
> approach is to include the source in debian/missing-sources.  They're
> both pretty frustrating choices to have to make, but they're the result
> of upstream shipping what is effectively compiled code in their source
> distribution.
> 

Repacking upstream these days is actually not that hard - you can add a Files-Excluded: line to debian/copyright, and uscan will automatically repack the upstream tarball and exclude those files. Make sure you edit debian/watch too, so the upstream version has a +dfsg1 appended. 

Example:
https://anonscm.debian.org/cgit/users/infinity0-guest/cpp-netlib.git/tree/debian/copyright?id=3cf4144d59bda11c1dcc2af7dba6592daa9a00bd
https://anonscm.debian.org/cgit/users/infinity0-guest/cpp-netlib.git/tree/debian/watch?id=3cf4144d59bda11c1dcc2af7dba6592daa9a00bd

I think this is neater than adding redundant things to debian/missing-sources.

X

-- 
GPG: 4096R/1318EFAC5FBBDBCE
git://github.com/infinity0/pubkeys.git

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozext-maintainers/attachments/20150204/bb46d057/attachment.sig>