[Pkg-mozext-maintainers] Bug#867542: 'invalid language tag' since 30c1fe69 [was: Re: Bug#867542: enigmail: can't decrypt messages in thunderbird]

[Jörg-Volker Peetz]

Hi Daniel,

Daniel Kahn Gillmor wrote on 07/12/17 02:55:
> Control: severity 867542 normal
> 
> Hi Jörg--
> 
> Over in https://bugs.debian.org/867542, you wrote:
> 
>> decryption of messages in thunderbird fails.
> 
> how does it fail?  does it hang?  show you an error message?

I have disabled automatic encryption. In the message window I see the encrypted
message (ASCII-armored GPG). After pressing the "decrypt" button from the
enigmail menu, nothing visible happens.

> 
>> The log of enigmail shows this:
>>
>> --- %< ---
>> 2017-07-07 08:34:46.501 [DEBUG] errorHandling.jsm: parseErrorOutputWith:
>> statusFlags = 00000020
>> 2017-07-07 08:34:46.501 [DEBUG] errorHandling.jsm: parseErrorOutputWith: return
>> with c.errorMsg =
>> 2017-07-07 08:34:46.501 [DEBUG] execution.jsm: EnigmailExecution.fixExitCode:
>> agentType: gpg exitCode: 0 statusFlags undefined
>> 2017-07-07 08:34:46.502 [CONSOLE]
>> 2017-07-07 08:34:46.502 [DEBUG] keyRing.jsm: createAndSortKeyList()
>> 2017-07-07 08:34:46.504 [ERROR] enigmailMessengerOverlay.js: messageDecryptCb:
>> caught exception: RangeError
>> Message: 'invalid language tag: en-US.UTF-8'
>> File:    resource://enigmail/time.jsm
>> Line:    48
>> Stack:   EnigmailTime.getDateTime at resource://enigmail/time.jsm:48:14
>> KeyObject at resource://enigmail/keyRing.jsm:1607:19
>> appendKeyItems at resource://enigmail/keyRing.jsm:1436:20
>> createKeyObjects at resource://enigmail/keyRing.jsm:1411:3
>> createAndSortKeyList at resource://enigmail/keyRing.jsm:1560:3
>> loadKeyList at resource://enigmail/keyRing.jsm:1283:3
>> EnigmailKeyRing.getAllKeys at resource://enigmail/keyRing.jsm:151:7
>> EnigmailKeyRing.getKeyById at resource://enigmail/keyRing.jsm:222:7
>> EnigmailDecryption.decryptMessageEnd at resource://enigmail/decryption.jsm:348:26
>> EnigmailDecryption.decryptMessage at resource://enigmail/decryption.jsm:553:20
>> Enigmail.msg.messageParseCallback at chrome://enigmail/content/enigmailMessengerOverlay.js:1005:19
>> Enigmail.msg.messageParse at chrome://enigmail/content/enigmailMessengerOverlay.js:926:5
>> Enigmail.msg.messageDecryptCb at chrome://enigmail/content/enigmailMessengerOverlay.js:764:9
>> _f at chrome://enigmail/content/enigmailMessengerOverlay.js:555:9
>> callbackWrapper at resource://enigmail/timer.jsm:38:9
>> --- >% ---
> 
> thanks for the logs.  Was it repeatable reliably with 1.9.8-1 ?  Are you
> able to get this to repeat with 1.9.8.1-1 (the version i uploaded to
> unstable today)?

Yes, it is repeatable reliably. I've tested with version 1.9.8.1-1 which also fails.

> 
>> Something seems odd with the language tag "en-US.UTF-8".
>>
>> The command "locale -a" shows on this system among others "en_US.utf8".
> 
> I am used to seeing en_US.UTF-8 for LANG, but not en-US.UTF-8.  Are you
> setting NSILOCALE_TIME anywhere in your environment?
>

$ locale
LANG=C.UTF-8
LANGUAGE=
LC_CTYPE="C.UTF-8"
LC_NUMERIC="C.UTF-8"
LC_TIME="C.UTF-8"
LC_COLLATE="C.UTF-8"
LC_MONETARY="C.UTF-8"
LC_MESSAGES="C.UTF-8"
LC_PAPER="C.UTF-8"
LC_NAME="C.UTF-8"
LC_ADDRESS="C.UTF-8"
LC_TELEPHONE="C.UTF-8"
LC_MEASUREMENT="C.UTF-8"
LC_IDENTIFICATION="C.UTF-8"
LC_ALL=

$ env | grep LOCALE

so NSILOCALE_TIME is not set.

>> For the moment I will revert back to the last working version 2:1.9.7-2.
> 
> The line you're getting an error on was definitely changed between 1.9.7
> and 1.9.8 (it was changed in 30c1fe69a7c62007f925d760efc832884aed4412,
> which overhauls the time calculations).
> 
> Maybe upstream (cc'ed here) can shed some light on this?
> 
>         --dkg
> 
The good news: the patch proposed by Patrick Brunschwig on top of version
1.9.8.1-1 makes enigmail work again for me.

Regards,
jvp.