[Pkg-mozext-maintainers] Bug#858079: xul-ext-sieve: makes files disappear from libjs-codemirror on upgrade

[Andreas Beckmann]

Package: xul-ext-sieve
Version: 0.2.3h+dfsg-2
Severity: serious
User: debian-qa at lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package removes files that
were installed by another package.
The removed files were already present before the package was installed,
they may have been shipped or created by a dependency.

This was observed on tests from jessie directly to sid as well as from 
stretch to sid.

>From the attached log (scroll to the bottom...):

1m41.4s ERROR: FAIL: debsums reports modifications inside the chroot:
  debsums: missing file /usr/share/javascript/codemirror/addon/edit/matchbrackets.js (from libjs-codemirror package)
  debsums: missing file /usr/share/javascript/codemirror/addon/search/searchcursor.js (from libjs-codemirror package)
  debsums: missing file /usr/share/javascript/codemirror/lib/codemirror.css (from libjs-codemirror package)
  debsums: missing file /usr/share/javascript/codemirror/lib/codemirror.js (from libjs-codemirror package)
  debsums: missing file /usr/share/javascript/codemirror/mode/sieve/sieve.js (from libjs-codemirror package)
  debsums: missing file /usr/share/javascript/codemirror/theme/eclipse.css (from libjs-codemirror package)

This code from the preinst looks extremely fishy
(I only looked at the diff between -1 and -2):

+    # versions prior to 0.2.3h+dfsg-2 either shipped a copy of codemirror or
+    # symlinks inside the CodeMirror directory. Make sure the directory is
+    # removed so it can be replaces with the symlink.
+    if [ -d /usr/share/xul-ext/sieve/chrome/chromeFiles/content/libs/CodeMirror ] ; then
+      rm -rf /usr/share/xul-ext/sieve/chrome/chromeFiles/content/libs/CodeMirror
     fi

1.) this sounds like you should use 
    dpkg-maintscript-helper dir_to_symlink ...
2.) there is no version check at all ...

but I still fail to see how this could remove the above files ...


cheers,

Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xul-ext-sieve_0.2.3h+dfsg-2.log.gz
Type: application/gzip
Size: 28537 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozext-maintainers/attachments/20170318/50e5f67d/attachment-0001.bin>