[Pkg-mpd-maintainers] Ubuntu changes to the mpd package

[Florian Schlichting]

Hi Steve,

I've just uploaded mpd 0.18.6-1, which includes the apport hook from
Ubuntu. Since mpd 0.18.5-1, XDG autostart file is installed in the
system-wide location, so all that's needed in order to run mpd as one's
own user instead of as a system service is to provide a ~/.mpdconf and
make sure it won't start on boot. From README.Debian:
    
    To prevent mpd from running as a system service, edit /etc/default/mpd and set
    "START_MPD=false" if you're using traditional sysvinit; in case of systemd,
    disable mpd.service by running "systemctl disable mpd.service". mpd is then
    started through the XDG autostart mechanism upon logging into your desktop
    environment, provided it can find a valid config file (such as ~/.mpdconf).

So I think all remaining modifications to the Ubuntu version of mpd can
now be dropped.

BTW if Ubuntu has an Upstart job file for mpd somewhere, I'd be very
happy to include that...

Florian


On Tue, Dec 03, 2013 at 10:13:21AM +1100, Steve Kowalik wrote:
> Hi,
> 
> Sorry about the length of time it has taken me to reply. I've also had
> to break threading since Thunderbird insisted on replying using HTML
> e-mail. :-(
> 
> On 20/11/13 08:17, Florian Schlichting wrote:
> > seeing you're the developer uploading the last few revisions of the
> > Ubuntu-patched mpd package, I hope you're the right one to discuss the
> > Ubuntu modifications with, aiming to reduce or even eliminate the
> > diff.
> >
> > From what I can see, the diff consists of the following changes:
> >
> >     - Add libmp3lame-dev to Build-Depends, and enable LAME.
> >
> > This one is bogus/obsolete - configure does not support --enable-lame
> > (it's really called --enable-lame-encoder), and libmp3lame-dev is
> > already in the list of build-dependencies.
> >
> > Suggestion: drop in Ubuntu
> 
> Sounds like a good plan.
> 
> >     - Read the user for the daemon from the config file in the init
> > script.
> >
> > This one is interesing - do you know what it is meant to achieve? If
> > this is meant to enable mpd to run as any other system user, support
> > is incomplete, as various things are configured specifically for the
> > mpd user in different places, e.g. postinst. If however this should
> > enable running mpd as the logged-in user, I think this should be done
> > differently: not starting mpd with an init script, but with an XDG
> > autostart file (the source package has a debian/mpd.desktop file,
> > which only gets installed into examples up to now). I'd be excited to
> > work with someone on a solution that works "out of the box" for any
> > logged-in user, but I'm unclear about support in different desktop
> > environments and how to provide the individual mpdconf files.
> >
> > On a side note, mpd_0.17.4-3ubuntu1.patch seems to be incomplete in
> > that it computes $USER in mpd.init.d, but never seems to use that
> > value? The second hunk of that patch probably got lost...
> >
> > Suggestion: drop in Ubuntu, work on a better replacement
> 
> 
> --- mpd-0.16.5/debian/mpd.init.d
> +++ mpd-0.16.5/debian/mpd.init.d
> @@ -65,7 +66,7 @@
>      PIDDIR=$(dirname "$PIDFILE")
>      if [ ! -d "$PIDDIR" ]; then
>          mkdir -m 0755 $PIDDIR
> -        chown mpd:audio $PIDDIR
> +        chown $USER:audio $PIDDIR
>      fi
> 
>      start-stop-daemon --start --quiet --oknodo --pidfile "$PIDFILE" \
> 
> That is the second hunk that is missing from the Saucy and Trusty
> uploads. Oops. Does it provide value at all?
> 
> >     - Move avahi-daemon from Suggests to Recommends.
> >
> > Why is that necessary? I would have expected avahi-daemon to be
> > installed on Ubuntu systems anyway, and leaving it as Suggests pleases
> > those people who try to keep it off their system
> >
> > Suggestion: Drop in Ubuntu, unless there's some policy requiring it
> > that I am not aware of
> 
> I'm not sure about this one, TBH. There was no justification when it was
> added to the Ubuntu package, so I'm content to just drop it.
> 
> >     - Added apport hook to include user configuration file.
> >
> > Can't hurt to add that to Debian as well, no? Should we look for the
> > system-wide mpd.conf as well, in case that is used?
> >
> > Suggestion: add to Debian
> 
> Excellent!
> 
> Thanks for chasing,
> -- 
>                                         Steve
> "I hate temporal mechanics!"
>          - Chief Miles O'Brien, Deep Space Nine