[Pkg-mpd-maintainers] Ubuntu changes to the mpd package

[Florian Schlichting]

Hi Steve,

seeing you're the developer uploading the last few revisions of the
Ubuntu-patched mpd package, I hope you're the right one to discuss the
Ubuntu modifications with, aiming to reduce or even eliminate the diff.

>From what I can see, the diff consists of the following changes:

    - Add libmp3lame-dev to Build-Depends, and enable LAME.

This one is bogus/obsolete - configure does not support --enable-lame
(it's really called --enable-lame-encoder), and libmp3lame-dev is
already in the list of build-dependencies.

Suggestion: drop in Ubuntu


    - Read the user for the daemon from the config file in the init script.

This one is interesing - do you know what it is meant to achieve? If
this is meant to enable mpd to run as any other system user, support is
incomplete, as various things are configured specifically for the mpd
user in different places, e.g. postinst. If however this should enable
running mpd as the logged-in user, I think this should be done
differently: not starting mpd with an init script, but with an XDG
autostart file (the source package has a debian/mpd.desktop file, which
only gets installed into examples up to now). I'd be excited to work
with someone on a solution that works "out of the box" for any logged-in
user, but I'm unclear about support in different desktop environments
and how to provide the individual mpdconf files.

On a side note, mpd_0.17.4-3ubuntu1.patch seems to be incomplete in that
it computes $USER in mpd.init.d, but never seems to use that value? The
second hunk of that patch probably got lost...

Suggestion: drop in Ubuntu, work on a better replacement


    - Move avahi-daemon from Suggests to Recommends.

Why is that necessary? I would have expected avahi-daemon to be
installed on Ubuntu systems anyway, and leaving it as Suggests pleases
those people who try to keep it off their system

Suggestion: Drop in Ubuntu, unless there's some policy requiring it that
I am not aware of


    - Added apport hook to include user configuration file.

Can't hurt to add that to Debian as well, no? Should we look for the
system-wide mpd.conf as well, in case that is used?

Suggestion: add to Debian


So, what do you think?

Florian