[Pkg-mpd-maintainers] Bug#998310: mpd: fails to start with "Assertion `sockets.empty()' failed."

[kaliko]

Hi,

03/11/2021 18:34, Max Kellermann wrote:
> On 2021/11/03 18:00, Benjamin Francois <kwyxz at kwyxz.org> wrote:
>> Confirmed, I commented out the pid_file line in /etc/mpd.conf and mpd now starts properly. Thanks Sir!
> 
> Okay, this is now fixed upstream:
> 
>   https://github.com/MusicPlayerDaemon/MPD/commit/14b3c0f0afe691739cdfc71d71adf740114d5a98
> 
> This problem affected only debug builds; this was a false-positive
> assertion failure, and my fix just works around this by reordering the
> destructor calls.
> 
> I was surprised to learn that all Debian packages appear to have
> debugging enabled, which adds a lot of unnecessary overhead.

I had a look at the 0.23.3-1 build and actually debhelper calls meson 
with "--wrap-mode=nodownload --buildtype=plain --prefix=/usr …" plus 
some *dir options [2]. Then indeed asserts are not disabled but it's not 
really a debug build either in meson terminology at least [0].

Anyway the way we build the package differs from upstream 
recommendations [1]: " --buildtype=debugoptimized -Db_ndebug=true".

Correct me if I'm wrong Max, but upstream considers this has an impact 
on runtime performances.

The question is then, should we add "b_ndebug=true"?
I did not find any mention of NBDEBUG in policies.

k.


[0] https://mesonbuild.com/Builtin-options.html#base-options
[1] https://mpd.readthedocs.io/en/stable/user.html#compiling-from-source
[2] cf. line 2228: 
https://buildd.debian.org/status/fetch.php?pkg=mpd&arch=amd64&ver=0.23.3-1&stamp=1635781704&raw=0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-mpd-maintainers/attachments/20211104/a4a2b08f/attachment.sig>