[Pkg-mpd-maintainers] Bug#1034236: mpd: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

[Florian Schlichting]

Control: severity ! important

On Fri, Apr 21, 2023 at 03:24:25PM +0200, Geoffroy Youri Berret wrote:
> Le 11/04/2023 à 23:52, Florian Schlichting a écrit :
> > […]
> > I think we should take a step back and think about how a freshly
> > installed mpd package should look like. I think it may actually be a
> > feature that the system mpd.service is not enabled and started on a
> > fresh install. On most desktop/laptop machines, leaving the system
> > service off and enabling the user service is probably the better thing
> > to do. How long has dh-installsystemd been disregarding our unit files?
> > We may want to add --no-enable when we apply that patch.
> > 
> > So I think in the case of mpd, perhaps nothing is severely broken
> > currently and this bug doesn't require fixing for bookworm. Instead, it
> > can perhaps be downgraded and fixed with the next regular upload, after
> > the release?
> 
> I agree, this is the best thing to do.
> The package is not broken enough to require a fix, it's actually not really
> broken it's only not enabling/starting system unit which, I believe, is not
> the main use of MPD anyway.

Since we agree, I don't think we need to wait any further and can get
ourselves off the release-critical bugs list right away :-)

Let's fix this first thing in trixie, and also add an override for
dh_installsystemd --no-enable

Florian