[Pkg-mpd-maintainers] Bug#1128846: mpd: FTBFS with glibc 2.43 due to openat2 redefinition

[Aurelien Jarno]

Source: mpd
Version: 0.24.6-1
Severity: important
Tags: ftbfs upstream
Justification: fails to build from source
User: debian-glibc at lists.debian.org
Usertags: glibc-2.43

Dear maintainer(s),

mpd fails to build from source with glibc 2.43, currently in
experimental. From the build log:

| [95/877] c++ -Isrc/io/libio.a.p -Isrc/io -I../src/io -Isrc -I../src -I. -I.. -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -std=c++20 -ffast-math -ftree-vectorize -Wcast-qual -Wdouble-promotion -Wmissing-declarations -Wshadow -Wunused -Wvla -Wwrite-strings -Wno-stringop-overflow -fno-threadsafe-statics -fmerge-all-constants -Wcomma-subscript -Wextra-semi -Wmismatched-tags -Woverloaded-virtual -Wsign-promo -Wsuggest-override -Wvolatile -Wvirtual-inheritance -Wno-missing-field-initializers -Wno-non-virtual-dtor -fvisibility=hidden -ffunction-sections -fdata-sections -D_GNU_SOURCE -g -O2 -ffile-prefix-map=/build/reproducible-path/mpd-0.24.6=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -MD -MQ src/io/libio.a.p/Open.cxx.o -MF src/io/libio.a.p/Open.cxx.o.d -o src/io/libio.a.p/Open.cxx.o -c ../src/io/Open.cxx
| FAILED: [code=1] src/io/libio.a.p/Open.cxx.o 
| c++ -Isrc/io/libio.a.p -Isrc/io -I../src/io -Isrc -I../src -I. -I.. -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -std=c++20 -ffast-math -ftree-vectorize -Wcast-qual -Wdouble-promotion -Wmissing-declarations -Wshadow -Wunused -Wvla -Wwrite-strings -Wno-stringop-overflow -fno-threadsafe-statics -fmerge-all-constants -Wcomma-subscript -Wextra-semi -Wmismatched-tags -Woverloaded-virtual -Wsign-promo -Wsuggest-override -Wvolatile -Wvirtual-inheritance -Wno-missing-field-initializers -Wno-non-virtual-dtor -fvisibility=hidden -ffunction-sections -fdata-sections -D_GNU_SOURCE -g -O2 -ffile-prefix-map=/build/reproducible-path/mpd-0.24.6=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -MD -MQ src/io/libio.a.p/Open.cxx.o -MF src/io/libio.a.p/Open.cxx.o.d -o src/io/libio.a.p/Open.cxx.o -c ../src/io/Open.cxx
| In file included from ../src/io/Open.cxx:12:
| ../src/system/linux/openat2.h:13:1: error: ‘int openat2(int, const char*, const open_how*, size_t)’ redeclared inline without ‘gnu_inline’ attribute
|    13 | openat2(int dirfd, const char *pathname,
|       | ^~~~~~~
| In file included from /usr/include/aarch64-linux-gnu/bits/fcntl-linux.h:492,
|                  from /usr/include/aarch64-linux-gnu/bits/fcntl.h:55,
|                  from /usr/include/fcntl.h:35,
|                  from ../src/system/linux/openat2.h:7:
| /usr/include/aarch64-linux-gnu/bits/fcntl-linux-fortify.h:36:1: note: ‘int openat2(int, const char*, const open_how*, size_t)’ previously defined here
|    36 | openat2 (int __dfd, const char *__filename, const struct open_how *__how,
|       | ^~~~~~~

...

| ninja: build stopped: subcommand failed.
| dh_auto_build: error: cd obj-aarch64-linux-gnu && LC_ALL=C.UTF-8 ninja -j128 -v returned exit code 1
| make: *** [debian/rules:123: binary] Error 25
| dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2

The full build log is available here [1].

The issue is due to a definition of the openat2 function, which is now
also provided by glibc 2.43 [2]. I believe that the issue is fixed
upstream [3], but I haven't tested the patch.

I would like to thanks Emanuele Rocca for doing the archive rebuild on a
fast arm64 server.

Regards
Aurelien

[1] https://people.debian.org/~ema/glibc-2.43-rebuilds/output-1/mpd_arm64.build
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=e271fb2e4d76903c77a302aaec1ca22ce31027d0;hb=f762ccf84f122d1354f103a151cba8bde797d521#l54
[3] https://github.com/MusicPlayerDaemon/MPD/commit/8caeedac3ed17491cd77240211ed13be80072a15

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien at aurel32.net                     http://aurel32.net