Bug#417750: FTBFS with GCC 4.3: missing #includes

[Martin Michlmayr]

Package: vlc
Version: 0.8.6.a.debian-6
Usertags: ftbfs-gcc-4.3
Tags: patch

Your package fails to build with GCC 4.3.  Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning.  In GCC 4.3, the C++ header
dependencies have been cleaned up.  The advantage of this is that
programs will compile faster.  The downside is that you actually
need to directly #include everything you use (but you really should
do this anyway, otherwise your program won't work with any compiler
other than GCC).  Some background of this can be found at
http://gcc.gnu.org/PR28080

You can reproduce this problem with gcc-snapshot (20070326-1 or higher)
from unstable. (Currently not available for i386, but for amd64, powerpc
and ia64.  I hope to have i386 binaries in the archive in ~3 weeks.)


> Automatic build of vlc_0.8.6.a.debian-6 on coconut0 by sbuild/ia64 0.49
...
>                  from src/skin_common.hpp:29,
>                  from src/theme_loader.hpp:28,
>                  from src/theme_loader.cpp:25:
> ../../../include/vlc_input.h: In function 'void vlc_input_item_Clean(input_item_t*)':
> ../../../include/vlc_input.h:165: warning: deprecated conversion from string constant to 'char*'
> src/theme_loader.cpp: In member function 'bool ThemeLoader::extractFileInZip(void*, const std::string&)':
> src/theme_loader.cpp:205: error: 'tolower' was not declared in this scope
> src/theme_loader.cpp: In function 'int gzopen_frontend(char*, int, int)':

--- modules/gui/skins2/src/theme_loader.cpp~	2007-04-04 13:13:02.000000000 +0000
+++ modules/gui/skins2/src/theme_loader.cpp	2007-04-04 13:13:36.000000000 +0000
@@ -30,6 +30,8 @@
 #include "../src/vlcproc.hpp"
 #include "../src/window_manager.hpp"
 
+#include <cctype>
+
 #ifdef HAVE_FCNTL_H
 #   include <fcntl.h>
 #endif

-- 
Martin Michlmayr
http://www.cyrius.com/