libquicktime 1.0.2
Fabian Greffrath
fabian.greffrath at lycos.de
Sat Jan 19 15:23:25 UTC 2008
Hi Loic,
thanks for the review.
Am Freitag, den 18.01.2008, 11:53 +0100 schrieb Loïc Minier:
> - you note "Explicitely disabled build with ALSA library"; this
> properly documents the change, but I fail to see the rationale; is
> this addressing a known bug? Why wouldn't we want ALSA support?
This is because of kfreebsd-* and hurd-*. I have not checked yet if
enabling ALSA affects libquicktime-dev dependencies. BTW, it seems
nobody has missed ALSA support by now. ;)
> - I see changes in 03-spurious-files-in-potfiles-in.dpatch which I
> can't match to a changelog entry (in one or more of r815, r1028,
> r1029)
True, this should also be in the list of updated patches.
> - minor: you touched 20-deprecated-headers and
> 21-export-quicktime_set_window; these are sourceful differences which
> should theoritically be mentionned in the changelog ;)
I only dpatch-edit-patch'ed them to see if the still apply cleanly. I
find it hard to write a changelog entry for this. ;)
> - I need a way to generate a tarball suitable for Debian; ideally both
> of these:
> * documented in debian/copyright ("download the upstream tarball and
> do foo")
> * implemented in debian/rules, for example in the "get-orig-source"
> target ("wget http://...; tar xzf ...; rm -rf ...; tar czf ...")
> but one would be enough
For 'rott' I documented this in README.Debian. Is this allright, too?
> I didn't review the new upstream release itself yet.
Oops, I didn't check the header files, too. :/
As a further step I'd like to CDBS'ify debian/rules to keep it smaller.
Cheers,
Fabian
More information about the pkg-multimedia-maintainers
mailing list