Bug#490401: VLC plugin should claim support for audio/x-m4a

[Petter Reinholdtsen]

tags 490401 + patch
thanks

This patch get the test page working.  It adds audio/x-m4a and
audio/mp4 to the two files vlcplugin.h and npvlc_rc.rc.  I am not sure
only these two files should be updated, but I can confirm that it work
with this patch in place.

The plugin is showing a black square with the text "no video" in the
middle when playing the audio.  I would prefer it to show some control
buttson (like restart and pause), instead of just the black screen,
but suspect that should be the topic for a different bug.

diff -ur vlc-0.8.6.e/mozilla/npvlc_rc.rc vlc-0.8.6.e.new/mozilla/npvlc_rc.rc
--- vlc-0.8.6.e/mozilla/npvlc_rc.rc	2007-11-21 22:23:46.000000000 +0000
+++ vlc-0.8.6.e.new/mozilla/npvlc_rc.rc	2008-07-12 06:39:58.000000000 +0000
@@ -39,7 +39,7 @@
             VALUE "InternalName", "npvlc\0"
             VALUE "CompanyName", "VideoLAN Team\0"
             VALUE "LegalCopyright", "Copyright \251 1996-2006 The VideoLAN Team\0"
-            VALUE "MIMEType", "audio/mpeg|audio/x-mpeg|video/mpeg|video/x-mpeg|video/mpeg-system|video/x-mpeg-system|video/mpeg4|audio/mpeg4|application/mpeg4-iod|application/mpeg4-muxcodetable|video/x-msvideo|video/quicktime|application/x-ogg|application/ogg|application/x-vlc-plugin|video/x-ms-asf-plugin|video/x-ms-asf|application/x-mplayer2|video/x-ms-wmv|application/x-google-vlc-plugin|audio/wav|audio/x-wav|audio/3gpp|video/3gpp|audio/3gpp2|video/3gpp2\0"
+            VALUE "MIMEType", "audio/mpeg|audio/x-mpeg|audio/x-m4a|video/mpeg|video/x-mpeg|video/mpeg-system|video/x-mpeg-system|video/mpeg4|audio/mpeg4|audio/mp4|application/mpeg4-iod|application/mpeg4-muxcodetable|video/x-msvideo|video/quicktime|application/x-ogg|application/ogg|application/x-vlc-plugin|video/x-ms-asf-plugin|video/x-ms-asf|application/x-mplayer2|video/x-ms-wmv|application/x-google-vlc-plugin|audio/wav|audio/x-wav|audio/3gpp|video/3gpp|audio/3gpp2|video/3gpp2\0"
             VALUE "FileExtents", "mp2,mp3,mpga,mpega|mp2,mp3,mpga,mpega|mpg,mpeg,mpe|mpg,mpeg,mpe|mpg,mpeg,vob|mpg,mpeg,vob|mp4,mpg4|mp4,mpg4|mp4,mpg4|mp4,mpg4|avi|mov,qt|ogg|ogg|vlc|asf,asx|asf,asx||wmv||wav|wav|3gp,3gpp|3gp,3gpp|3g2,3gpp2|3g2,3gpp2\0"
             VALUE "FileOpenName", "MPEG audio|MPEG audio|MPEG video|MPEG video|MPEG video|MPEG video|MPEG-4 video|MPEG-4 audio|MPEG-4 video|MPEG-4 video|AVI video|QuickTime video|Ogg stream|Ogg stream|VLC plugin|Windows Media video|Windows Media video|Windows Media plugin|Windows Media video|Google VLC plugin|WAV audio|WAV audio|3GPP audio|3GPP video|3GPP2 audio|3GPP2 video\0"
         END
diff -ur vlc-0.8.6.e/mozilla/vlcplugin.h vlc-0.8.6.e.new/mozilla/vlcplugin.h
--- vlc-0.8.6.e/mozilla/vlcplugin.h	2007-11-21 22:23:46.000000000 +0000
+++ vlc-0.8.6.e.new/mozilla/vlcplugin.h	2008-07-12 06:39:42.000000000 +0000
@@ -128,6 +128,7 @@
     /* MPEG-1 and MPEG-2 */ \
     "audio/mpeg:mp2,mp3,mpga,mpega:MPEG audio;" \
     "audio/x-mpeg:mp2,mp3,mpga,mpega:MPEG audio;" \
+    "audio/x-m4a:m4a:MPEG audio;" \
     "video/mpeg:mpg,mpeg,mpe:MPEG video;" \
     "video/x-mpeg:mpg,mpeg,mpe:MPEG video;" \
     "video/mpeg-system:mpg,mpeg,mpe,vob:MPEG video;" \
@@ -135,6 +136,7 @@
     /* MPEG-4 */ \
     "video/mpeg4:mp4,mpg4:MPEG-4 video;" \
     "audio/mpeg4:mp4,mpg4:MPEG-4 audio;" \
+    "audio/mp4:mp4,mpg4:MPEG-4 audio;" \
     "application/mpeg4-iod:mp4,mpg4:MPEG-4 video;" \
     "application/mpeg4-muxcodetable:mp4,mpg4:MPEG-4 video;" \
     /* AVI */ \

I was unable to find any rules to generate npvlc_rc.rc from the
content available elsewhere.  It surprised me that the source had
duplicated the information. :)

Happy hacking,
-- 
Petter Reinholdtsen