Bug#487252: libraries linked with libX11 on GNU/kFreeBSD

[Reinhard Tartler]

The following message is a courtesy copy of an article
that has been posted to gmane.comp.video.ffmpeg.devel as well.

Måns Rullgård <mans at mansr.com> writes:

> Reinhard Tartler wrote:
>>
>> ffmpeg-free
>
> Sorry, don't know what that is.  The name suggests it might be something
> without ffmpeg, so why are you asking about it here?

I'm sorry, I should have stripped that out while forwarding the
bugreport. 'ffmpeg-free' is an internal obsolute interim name for the
package. It has already been renamed.

>
>> links with -Wl,--as-needed on GNU/Linux, so the resulting
>> libraries are not linked with libX11. This is something required by VLC.
>
> I'm confused.  Does VLC require libX11, or does is forbid it?  I find
> both kind of hard to believe.

The reporter says that the configure script should behave on
gnu/kfreebsd the same as on Linux. I tend to agree with him, so I'm
forwarding that patch to you.

>
>> On GNU/kFreeBSD, -Wl,--as-needed is not used, so VLC fails to build.
>> Please find below a patch to fix that.
>>
>> --- ffmpeg-free-0.svn20080206.orig/configure
>> +++ ffmpeg-free-0.svn20080206/configure
>
> OMG, that's old.

Yes, but I've chcked that this patch applies to current trunk perfectly.

>> @@ -1289,6 +1289,9 @@
>>          SLIB_UNINSTALL_EXTRA_CMD='rm -f
>>          "$(LIBDIR)"/$(LIBPREF)$(NAME)_dll.a
>>          "$(LIBDIR)"/$(LIBPREF)$(NAME)_dll.lib'
>>          vhook="no"
>>          ;;
>> +    gnu/kfreebsd)
>> +        LDLATEFLAGS="-Wl,--as-needed $LDLATEFLAGS"
>> +        ;;
>>
>>      *)
>>          targetos="${targetos}-UNKNOWN"
>
> The use of this flag should depend on the linker, not the OS.  If
> existing code sets this based on OS, that code is wrong and should
> be fixed.  Patches adding incorrect code are rejected, regardless
> of what already exists.

I see.

The patch in question here however does not really add code, though.

>> This patch originates from Aurelien Jarno <aurel32 at debian.org> and has
>
> Oh, Debian.  I might have guessed. 

Yes, you could have seen that as well from my email adress as well.

> The Debian FFmpeg package is indeed about as free of FFmpeg as you can
> get.

I don't really understand this comment. If it is a reference to the very
unfortunate naming, be assured that that name does not appear in any
released debian version. Same applies for ubuntu, btw. (I'm the package
maintainer for ffmpeg in both distributions).

>> been applied to the debian package. Please consider applying it to svn
>> as well.
>
> I take something being applied to a debian package as a warning sign.

Feel free to contact me either privately or by any other means if you
spot something that can be improved in the debian package.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4