Bug#560052: The real fix

[Adrian Knoth]

On Thu, Dec 10, 2009 at 04:10:18PM +0100, Fabian Greffrath wrote:

>> So we need a newer VAMP SDK in Debian. After that, this intermediate
>> patch can be removed:
>>
>>     http://git.debian.org/?p=pkg-multimedia/ardour.git;a=commitdiff;h=347e34548cd877123865ddd65339398123f6b6a0
>
> But AFAIUI after removal of this patch we would still include the  
> headers shipped in the ardour source tree but link against the Debian  
> system library. 

You're right. This somewhat just hides the bug as long as ardour's VAMP
source matches the system's VAMP source.


> Wouldn't it make more sense to always use the Debian  package's
> headers then?

ACK, I was saying too much. It seems reasonable to keep this patch.


> BTW, shouldn't the variable, that gets commented out by the patch, be  
> called CPPPATH instead of CPPATH (i.e. three P instead of only 2)?
> <http://www.scons.org/doc/0.92/HTML/scons-user/x537.html>

Probably yes. I've told upstream about it.


Cheerio

-- 
mail: adi at thur.de  	http://adi.thur.de	PGP/GPG: key via keyserver