audacity 1.3.7-1 ready

[Reinhard Tartler]

Fabian Greffrath <greffrath at leat.rub.de> writes:

> Reinhard Tartler schrieb:
>> Btw, on a short code inspection I found out that in src/FFmpeg.cpp there
>> is code that looks for ffmpeg libraries and dynamically loads them if
>> they are available. That code seems rather inconsistent, it talks about
>> libavformat, but loads and checks for symbols in libavcodec, maybe there
>> is just some misunderstanding.
>
> Indeed, the audacity binary is not linked against libav{codec,format}
> but instead both libraries are loaded on demand. You even have to ask
> for it in the preferences dialog. At least, when configured with the
> --with-ffmpeg=system confflag, it finds the right ones (and not what is
> reported in #514333).
>
> I am tempted to forcedly hack '-lavcodec -lavformat' into audacity's
> ldflags...

I'm a bit confused. You mean that '--with-ffmpeg=system' you still need
to patch the ldflags in the build scripts? If yes, then I didn't
understand what --with-ffmpeg=system actually if for. If no, then we
should probably do that.

>> Has someone checked if audacity works with libavcodec52? Or is that
>> restricted to libavcodec51?
>
> Yes, I have just built audacity 1.3.6-3 against the ffmpeg libraries
> from experimental on my alpha and it worked. I haven't actually tested
> loading, playing and saving files, though. No sound hardware on alpha...

excellent!

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4