Bug#370599: OpenCORE AMR library

[Stanislav Brabec]

Andres Mejia wrote:

> I would like this library to be a replacement for the current libamr libraries.
> However, the opencore framework is missing an amr-wb encoder. With this in mind, 
> perhaps the SONAME for the opencore-amr libraries can be bumped and the old 
> libamr-wb libraries can be broken up to have a libamrwb_encoder library. What is 
> your opinion? Also, are you interesting in maintaining this library?

Are you sure, that opencore-amr uses the same API?

The old amrwb / amrnb API is not my work. I wrote only a shared library
wrapper. That is why I don't think, that splitting or changing anything
there is a good idea. It is intended to work with applications wrote for
3GPP reference implementation.

But I can create a new version with a symlink to libamrwb_encoder, if it
helps.

However I doubt, that anybody wants to emulate all features of the old
3GPP API. It was was never intended for shared library:

Changing behavior of some functions in the shared library depending on
a value of a macro is a pretty ugly thing which required ugly hacks in
the header file:

#define IF2 1
#include <amrwb.h>
E_IF_encode()

does something different than:

#include <amrwb.h>
E_IF_encode()

3GPP reference implementation does not follow common function name
prefix convention for library calls, e. g. name function
amrwb_E_IF_encode() instead of E_IF_encode(). It could make problems in
code.

No, I don't want to maintain amr code. I know nothing about AMR
implementations. I only did the hacky work to adapt existing code from
3GPP intended to statical linking to a shared library.

But I can link to any project from my pages and recommend it instead of
my hack with uncertain legal status.


________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx