[Bug 481448] [NEW] VLC lacks build-dep on libupnp3-dev

[Whoopie]

Hi,

>> diff -u vlc-1.0.2/debian/vlc-nox.install vlc-1.0.2/debian/vlc-nox.install
>> --- vlc-1.0.2/debian/vlc-nox.install
>> +++ vlc-1.0.2/debian/vlc-nox.install
>> @@ -67,7 +67,16 @@
>>  usr/lib/vlc/codec/libtheora_plugin.so
>>  usr/lib/vlc/codec/libtwolame_plugin.so
>>  usr/lib/vlc/codec/libvorbis_plugin.so
>> -usr/lib/vlc/control
>> +usr/lib/vlc/control/libdbus_plugin.so
>> +usr/lib/vlc/control/libgestures_plugin.so
>> +usr/lib/vlc/control/libhotkeys_plugin.so
>> +usr/lib/vlc/control/libhttp_plugin.so
>> +usr/lib/vlc/control/liblirc_plugin.so
>> +usr/lib/vlc/control/libmotion_plugin.so
>> +usr/lib/vlc/control/librc_plugin.so
>> +usr/lib/vlc/control/libshowintf_plugin.so
>> +usr/lib/vlc/control/libsignals_plugin.so
>> +usr/lib/vlc/control/libtelnet_plugin.so
>>  usr/lib/vlc/demux
>>  usr/lib/vlc/gui/libncurses_plugin.so
>>  usr/lib/vlc/meta_engine
> 
> I don't understand this. Previously, the while usr/lib/vlc/control
> directory was installed. Now you make the list explicit. I don't see any
> practical difference in the resulting vlc-nox package, but I want to ask
> here to be sure if this change is indeed spurious.
> 

I added /usr/lib/vlc/control/libglobalhotkeys_plugin.so to vlc.install
as it has some X dependencies. That's why I had to add the rest of the
control plugins to vlc-nox.install explicitely.

> 
>> diff -u vlc-1.0.2/debian/vlc.install vlc-1.0.2/debian/vlc.install
>> --- vlc-1.0.2/debian/vlc.install
>> +++ vlc-1.0.2/debian/vlc.install
>> @@ -3,6 +3,7 @@
>>  usr/lib/vlc/access/libx11_screen_plugin.so
>>  usr/lib/vlc/codec/libsdl_image_plugin.so
>>  usr/lib/vlc/codec/libx264_plugin.so
>> +usr/lib/vlc/control/libglobalhotkeys_plugin.so
>>  usr/lib/vlc/gui/libqt4_plugin.so
>>  usr/lib/vlc/gui/libskins2_plugin.so
>>  usr/lib/vlc/misc/libnotify_plugin.so
> 
> This plugin seems to come from the added libxcb-keysyms1-dev, right?
>

Yes.

> Do the other build dependencies libupnp3-dev and libcddb2-dev not
> produce additional functionality? upnp seem to have its sources in
> modules/services_discover, and is declared in:

/usr/lib/vlc/services_discovery/libupnp_intel_plugin.so is automatically
installed in vlc-nox.install with the "usr/lib/vlc/services_discovery"
line.

libcddba_plugin.so is just linked against the libcddb2:
  ldd /usr/lib/vlc/access/libcdda_plugin.so
        ...
	libcddb.so.2 => /usr/lib/libcddb.so.2 (0xb7868000)
	libvlccore.so.2 => /usr/lib/libvlccore.so.2 (0xb7790000)
	libc.so.6 => /lib/tls/i686/cmov/libc.so.6 (0xb764c000)
	/lib/ld-linux.so.2 (0xb78b4000)
	...

> 
> ,----[ modules/services_discovery/Modules.am ]
> | SOURCES_sap = sap.c
> | SOURCES_hal = hal.c
> | SOURCES_shout = shout.c
> | SOURCES_upnp_cc = upnp_cc.cpp
> | SOURCES_upnp_intel = upnp_intel.cpp upnp_intel.hpp
> | SOURCES_bonjour = bonjour.c
> | SOURCES_podcast = podcast.c
> | SOURCES_mtp = mtp.c
> | SOURCES_udev = udev.c
> `----
> 
> without having testbuilt it it seems to me that upnp_cc.so and
> upnp_intel.so should have been created, but are left uninstalled in the
> package. Is this a correct guess?
> 
No, only the Intel UPnP module is built and installed, the other one is
deprecated, as I understood.

> Have you checked that the upnp functionality actually works?
> 

Yes, works fine against my mediatomb UPnP server.

> for cddb, it seems that indeed no additional module is created, and only
> files in modules/access/cdda/* check the define HAVE_LIBCDDB.
> 
> The "other" patch for lucid seems largely redundant, but
> debian/changelog is missing the upnp change.
>

upnp change is missing as it was added in vlc_1.0.3-1 in Debian and
vlc_1.0.3-1ubuntu1 in Lucid.


Best regards,
Whoopie