[SCM] FFmpeg packaging branch, master, updated. debian/0.5+svn20090706-1-6-gf90dd6a

[Andres Mejia]

On Monday 07 September 2009 03:46:54 Fabian Greffrath wrote:
> Andres Mejia schrieb:
> > I still prefer using a variable to disable the restrictions rather than
> > having to comment out the line. Perhaps a more appropriate variable could
> > be used, like "build_restricted_encoders".
> 
> We want to encourage people to use the debimedia variant instead. I
> think commenting out a line is still more intuitive than setting a
> variable that you have to grep out of the code anyway. Moreover, the
> commented out line appears in the diff.gz so the change is documented,
> which isn't the case for a set or unset environment variable.
> 

If we wanted to encourage people to use debimedia, than we shouldn't even 
mention that they can just comment out that line. Also, not to insult anyone, 
but if we wanted to encourage people to use debimedia, we should do a better job 
of keeping debimedia up to date.

Also, I don't see how this is more intuitive. What I see is that anyone tracking 
the ffmpeg packaging will have to keep commenting out that line every time they 
want to build the restricted encoders. It would be much easier if we would just 
make use of DEB_BUILD_OPTIONS for this kind of case, especially since it's 
frequently used.

Also, I'm not sure what you mean by documentation, but the change would be set 
in the build logs, when it would (or use to) show whether or not 
'internalencoders' was set. It would also be seen if encoders were being 
disabled through the ffmpeg build system and it can be checked again with 'ffmpeg 
-formats'.

-- 
Regards,
Andres