Comments regarding liblo_0.26~repack-1_i386.changes
siretart at tauware.de
Sat Sep 19 09:28:14 UTC 2009
Barry deFreese <ftpmaster at debian.org> writes:
> Hello maintainer,
> I am going to accept liblo, but you should fix a couple of minor
> issues on your next upload.
> Uwe Koloska should be added as a Copyright holder in debian/copyright.
> src/tools/oscdump.* are (C) Kentaro Fukuchi <fukuchi at megaui.net> and
> should be noted. You should probably state the reasons for the repack
> in debian/README.source.
To address these comments, I've included the following patch to our
Author: Reinhard Tartler <siretart at tauware.de>
Date: Sat Sep 19 11:26:37 2009 +0200
based on the comments from Barry deFreese <ftpmaster at debian.org> mading
during the review of the package as ftp-master.
diff --git a/debian/README.Source b/debian/README.Source
new file mode 100644
@@ -0,0 +1,3 @@
+The upstream tarball has been repackaged because it includes a sourceless binary,
+build/premake4.exe which is only used for Windows builds. This file has been thus
+removed from the upstream tarball.
diff --git a/debian/copyright b/debian/copyright
index 906c71c..a5826b7 100644
@@ -5,17 +5,16 @@ It was downloaded from: <http://liblo.sourceforge.net/>
Liblo was initially written by Steve Harris <steve at totl.net>, but is now
maintained by Stephen Sinclair <sinclair at music.mcgill.ca>
-liblo is copyright 2004-2009 Steve Harris, Stephen Sinclair and others, see
+liblo is copyright 2004-2009 Steve Harris, Stephen Sinclair, Uwe Koloska and others, see
the AUTHORS file for a list of contributors.
liblo is released under the GNU Lesser General Public License, version 2.1 or,
at your option, any later version, found on Debian GNU/Linux systems in the
+src/tools/oscdump.* are (C) Kentaro Fukuchi <fukuchi at megaui.net>. They are used to
+produce the binaries in the liblo-tools package.
The packaging of liblo is released under the GNU General Public License,
version 2, see above. It is copyright 2004-2006 Robert Jordens, and
2008-2009 Felipe Sateler.
-The upstream tarball has been repackaged because it includes a sourceless binary,
-build/premake4.exe which is only used for Windows builds. This file has been thus
-removed from the upstream tarball.
> It would also probably have been better to use ~dfsg for your repacked
> version to make it more clear that it was repacked for DFSG.
we will consider this on the next upstream revision.
Reinhard Tartler, KeyID 945348A4
More information about the pkg-multimedia-maintainers