Adopting jack-tools

[Arnout Engelen]

On Fri, Aug 20, 2010 at 02:57:57PM +0200, Alessio Treglia wrote:
> I've been doing some work on the package, license information seems
> missing in the sources.
> Plus, no license is provided with the original tarball.

Right - the README does contain a copyright line, states it's GPL and links to
gnu.org, but copyright information is not in every file and the GPL text is not
included.

Can/should we include copyright information in each file, or do we need 
upstream to take care of this? Unless you beat me to it I'll prepare a patch 
somewhere next week to add copyright/license information to each source file
and send it to upstream.

As for not including the GPL license text, is that a problem?


Regards,

Arnout

> 
> alessio at quadromatic:~/Documenti/devel/debian/git/pkg-multimedia/jack-tools$
> licensecheck --copyright -r .
> ./jack.udp.c: UNKNOWN
>   [Copyright: rohan drape, 2003-2010 *****/]
> 
> ./jack.dl.c: UNKNOWN
>   [Copyright: rohan drape, 2003-2008 *****/]
> 
> ./jack.transport.c: UNKNOWN
>   [Copyright: rohan drape, 2006-2008 *****/]
> 
> ./jack.record.c: UNKNOWN
>   [Copyright: rohan drape, 2003-2006 *****/]
> 
> ./common/img.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/jack-client.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/signal-clip.h: *No copyright* UNKNOWN
> 
> ./common/client.h: *No copyright* UNKNOWN
> 
> ./common/jack-transport.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/file.h: *No copyright* UNKNOWN
> 
> ./common/jack-transport.h: *No copyright* UNKNOWN
> 
> ./common/signal-print.h: *No copyright* UNKNOWN
> 
> ./common/network.h: *No copyright* UNKNOWN
> 
> ./common/byte-order.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/img.h: *No copyright* UNKNOWN
> 
> ./common/jack-port.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/xregcomp.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/failure.h: *No copyright* UNKNOWN
> 
> ./common/signal-copy.h: *No copyright* UNKNOWN
> 
> ./common/ximg.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/client.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/float.h: *No copyright* UNKNOWN
> 
> ./common/time-current.h: *No copyright* UNKNOWN
> 
> ./common/sound-file.h: *No copyright* UNKNOWN
> 
> ./common/signal-print.c: UNKNOWN
>   [Copyright: rohan drape, 2005 */]
> 
> ./common/memory.h: *No copyright* UNKNOWN
> 
> ./common/time-current.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/time-timeval.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/img-ppm.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/time-ntp.h: *No copyright* UNKNOWN
> 
> ./common/byte-order.h: *No copyright* UNKNOWN
> 
> ./common/signal-interleave.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/img-ppm.h: *No copyright* UNKNOWN
> 
> ./common/print.h: *No copyright* UNKNOWN
> 
> ./common/time-timespec.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/osc.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/int.h: *No copyright* UNKNOWN
> 
> ./common/ximg.h: *No copyright* UNKNOWN
> 
> ./common/signal-interleave.h: *No copyright* UNKNOWN
> 
> ./common/sound-file.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/time-timeval.h: *No copyright* UNKNOWN
> 
> ./common/jack-ringbuffer.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/network.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/observe-signal.h: *No copyright* UNKNOWN
> 
> ./common/jack-client.h: *No copyright* UNKNOWN
> 
> ./common/xregcomp.h: *No copyright* UNKNOWN
> 
> ./common/signal-interpolate.h: *No copyright* UNKNOWN
> 
> ./common/time-timespec.h: *No copyright* UNKNOWN
> 
> ./common/signal-clip.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/osc.h: *No copyright* UNKNOWN
> 
> ./common/observe-signal.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/signal-interpolate.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/jack-port.h: *No copyright* UNKNOWN
> 
> ./common/file.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/signal-copy.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/memory.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./common/jack-ringbuffer.h: *No copyright* UNKNOWN
> 
> ./common/time-ntp.c: UNKNOWN
>   [Copyright: rohan drape, 2005-2006 */]
> 
> ./autogen.sh: *No copyright* UNKNOWN
> 
> ./jack.dl.h: *No copyright* UNKNOWN
> 
> ./help/sin.c: *No copyright* UNKNOWN
> 
> ./jack.play.c: UNKNOWN
>   [Copyright: rohan drape, 2003-2008 *****/]
> 
> ./jack.scope.c: UNKNOWN
>   [Copyright: rohan drape, 1998-2006 *****/]
> 
> ./jack.plumbing.c: UNKNOWN
>   [Copyright: rohan drape, 2003-2006 *****/]
> 
> ./jack.osc.c: UNKNOWN
>   [Copyright: rohan drape, 2004-2006 *****/]
> 
> 
> 
> -- 
> Alessio Treglia <alessio at alessiotreglia.com>
> Debian & Ubuntu Developer | Homepage: http://www.alessiotreglia.com
> 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0