review ghostess

[Reinhard Tartler]

On Wed, Aug 25, 2010 at 23:46:18 (CEST), rosea grammostola wrote:

> On Wed, Aug 25, 2010 at 10:56 PM, Arnout Engelen <arnouten at bzzt.net> wrote:
>
>> On Wed, Aug 25, 2010 at 10:29:00PM +0200, rosea grammostola wrote:
>> > As a not very experienced packager, I've added ghostess
>> >
>> > http://git.debian.org/git/pkg-multimedia/ghostess.git/
>> >
>> > Comments are welcome.
>>
>> I'm very new at this still also, but a good place to start would be fixing
>> any
>> lintian warnings/errors:
>>
>> Now running lintian...
>> W: ghostess source: changelog-should-mention-nmu
>>
>
> maintainer is debian multimedia team right?

yes, the correct maintainer field is documented on the DevelopPackaging
wiki page.
>
>> W: ghostess source: source-nmu-has-incorrect-version-number 20100326-1
>>
>
> this is not allowed?
>
>
>> W: ghostess source: no-human-maintainers
>>
>

with the correct maintainer field, these three issue should go away.

>
>
>> E: ghostess: copyright-contains-dh_make-todo-boilerplate
>>
>
> hmm ok
>
>
>> W: ghostess: binary-without-manpage usr/bin/ghostess
>> W: ghostess: binary-without-manpage usr/bin/ghostess_universal_gui
>> Finished running lintian.
>>
>
> Should I add a manpage? Any recommendations how (it looks the README file
> contains manpage info)?
>
> Two manpages?

Bonus points for generating the manpage from something that is
maintained upstream. Outdated, wrong manpages are worse than no manpages
at all. If you write a new manpage, at least try to get them submitted upstream.

> Should there be a menu entry or desktop file?

I think desktop files are more important nowadays, but YMMV.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4